Fokko commented on code in PR #771:
URL: https://github.com/apache/iceberg-rust/pull/771#discussion_r1877895355
##
crates/iceberg/src/expr/visitors/expression_evaluator.rs:
##
@@ -273,7 +273,7 @@ mod tests {
))])
.build()?;
-let spec = BoundPa
Fokko commented on code in PR #771:
URL: https://github.com/apache/iceberg-rust/pull/771#discussion_r1877888621
##
crates/iceberg/src/spec/table_metadata.rs:
##
@@ -119,9 +119,11 @@ pub struct TableMetadata {
/// ID of the table’s current schema.
pub(crate) current_sch
Fokko commented on code in PR #771:
URL: https://github.com/apache/iceberg-rust/pull/771#discussion_r1877890713
##
crates/iceberg/src/spec/table_metadata.rs:
##
@@ -776,17 +782,12 @@ pub(super) mod _serde {
.map(|x| (x.spec_id(), Arc::new(x))),
c-thiel commented on code in PR #771:
URL: https://github.com/apache/iceberg-rust/pull/771#discussion_r1877599173
##
crates/iceberg/src/spec/partition.rs:
##
@@ -244,21 +173,21 @@ pub struct UnboundPartitionField {
/// Unbound partition spec can be built without a schema and la
liurenjie1024 commented on code in PR #771:
URL: https://github.com/apache/iceberg-rust/pull/771#discussion_r1877484452
##
crates/iceberg/src/spec/partition.rs:
##
@@ -244,21 +173,21 @@ pub struct UnboundPartitionField {
/// Unbound partition spec can be built without a schema