liurenjie1024 commented on PR #444:
URL: https://github.com/apache/iceberg-rust/pull/444#issuecomment-2213293057
Thanks @Xuanwo for this pr! And @sdd @Fokko for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
liurenjie1024 merged PR #444:
URL: https://github.com/apache/iceberg-rust/pull/444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
Xuanwo commented on PR #444:
URL: https://github.com/apache/iceberg-rust/pull/444#issuecomment-2213258492
All comments have been resovled. PTAL @liurenjie1024 @Fokko @sdd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
Xuanwo commented on code in PR #444:
URL: https://github.com/apache/iceberg-rust/pull/444#discussion_r1668139594
##
README.md:
##
@@ -17,89 +17,62 @@
~ under the License.
-->
-# Apache Iceberg Rust
-
-Native Rust implementation of [Apache Iceberg](https://iceberg.apache.or
Fokko commented on code in PR #444:
URL: https://github.com/apache/iceberg-rust/pull/444#discussion_r1668090507
##
README.md:
##
@@ -17,89 +17,62 @@
~ under the License.
-->
-# Apache Iceberg Rust
-
-Native Rust implementation of [Apache Iceberg](https://iceberg.apache.org
Xuanwo commented on PR #444:
URL: https://github.com/apache/iceberg-rust/pull/444#issuecomment-2213162101
> Looks good. I'm not normally as picky about getting the english exactly
correct as long as it is understandable, but for the main Readme.md I think we
want it perfect :-)
Thank
sdd commented on code in PR #444:
URL: https://github.com/apache/iceberg-rust/pull/444#discussion_r1668065947
##
README.md:
##
@@ -17,89 +17,62 @@
~ under the License.
-->
-# Apache Iceberg Rust
-
-Native Rust implementation of [Apache Iceberg](https://iceberg.apache.org/)
sdd commented on code in PR #444:
URL: https://github.com/apache/iceberg-rust/pull/444#discussion_r1668065324
##
README.md:
##
@@ -17,89 +17,62 @@
~ under the License.
-->
-# Apache Iceberg Rust
-
-Native Rust implementation of [Apache Iceberg](https://iceberg.apache.org/)
liurenjie1024 commented on PR #444:
URL: https://github.com/apache/iceberg-rust/pull/444#issuecomment-2211700081
Let's wait to see if @Fokko have any suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
