Re: [PR] decimal physicial type mapping [iceberg-python]

2025-04-05 Thread via GitHub
Fokko commented on code in PR #1839: URL: https://github.com/apache/iceberg-python/pull/1839#discussion_r2021041283 ## pyiceberg/io/pyarrow.py: ## @@ -2350,8 +2351,19 @@ def data_file_statistics_from_parquet_metadata( stats_col.iceberg_type, statisti

Re: [PR] decimal physicial type mapping [iceberg-python]

2025-04-04 Thread via GitHub
Fokko commented on code in PR #1839: URL: https://github.com/apache/iceberg-python/pull/1839#discussion_r2020991374 ## pyiceberg/io/pyarrow.py: ## @@ -2350,8 +2351,19 @@ def data_file_statistics_from_parquet_metadata( stats_col.iceberg_type, statisti

Re: [PR] decimal physicial type mapping [iceberg-python]

2025-03-31 Thread via GitHub
redpheonixx commented on code in PR #1839: URL: https://github.com/apache/iceberg-python/pull/1839#discussion_r2021037350 ## pyiceberg/io/pyarrow.py: ## @@ -2350,8 +2351,19 @@ def data_file_statistics_from_parquet_metadata( stats_col.iceberg_type, st

Re: [PR] decimal physicial type mapping [iceberg-python]

2025-03-27 Thread via GitHub
redpheonixx commented on PR #1839: URL: https://github.com/apache/iceberg-python/pull/1839#issuecomment-2748836848 Hi @kevinjqliu @Fokko I have updated the code as per previous PR #1799 comments please note that 1. We need Decimal as to create pa.array of decimal 128 type it ac

[PR] decimal physicial type mapping [iceberg-python]

2025-03-24 Thread via GitHub
redpheonixx opened a new pull request, #1839: URL: https://github.com/apache/iceberg-python/pull/1839 This pull request addresses the handling of decimal physical type matching in Parquet. It implements rules such that: For precision ≤ 9, values are stored as `int32`. For precision ≤ 1