BsoBird closed pull request #10623: core:Refactor the code of HadoopTableOptions
URL: https://github.com/apache/iceberg/pull/10623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
BsoBird commented on code in PR #10623:
URL: https://github.com/apache/iceberg/pull/10623#discussion_r1677327810
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java:
##
@@ -159,18 +169,124 @@ public void commit(TableMetadata base, TableMetadata
metadata)
BsoBird commented on code in PR #10623:
URL: https://github.com/apache/iceberg/pull/10623#discussion_r1669863261
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java:
##
@@ -159,18 +169,124 @@ public void commit(TableMetadata base, TableMetadata
metadata)
BsoBird commented on code in PR #10623:
URL: https://github.com/apache/iceberg/pull/10623#discussion_r1669863261
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java:
##
@@ -159,18 +169,124 @@ public void commit(TableMetadata base, TableMetadata
metadata)
BsoBird commented on code in PR #10623:
URL: https://github.com/apache/iceberg/pull/10623#discussion_r1673326440
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java:
##
@@ -291,137 +407,171 @@ Path versionHintFile() {
return metadataPath(Util.VERSION_
BsoBird commented on code in PR #10623:
URL: https://github.com/apache/iceberg/pull/10623#discussion_r1669894107
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java:
##
@@ -291,137 +407,171 @@ Path versionHintFile() {
return metadataPath(Util.VERSION_
BsoBird commented on code in PR #10623:
URL: https://github.com/apache/iceberg/pull/10623#discussion_r1673311069
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java:
##
@@ -291,137 +407,171 @@ Path versionHintFile() {
return metadataPath(Util.VERSION_
BsoBird commented on code in PR #10623:
URL: https://github.com/apache/iceberg/pull/10623#discussion_r1669877984
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java:
##
@@ -159,18 +169,124 @@ public void commit(TableMetadata base, TableMetadata
metadata)
BsoBird commented on code in PR #10623:
URL: https://github.com/apache/iceberg/pull/10623#discussion_r1669866534
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java:
##
@@ -159,18 +169,124 @@ public void commit(TableMetadata base, TableMetadata
metadata)
BsoBird commented on code in PR #10623:
URL: https://github.com/apache/iceberg/pull/10623#discussion_r1669916171
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java:
##
@@ -159,18 +169,124 @@ public void commit(TableMetadata base, TableMetadata
metadata)
BsoBird commented on code in PR #10623:
URL: https://github.com/apache/iceberg/pull/10623#discussion_r1669885260
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java:
##
@@ -291,137 +407,171 @@ Path versionHintFile() {
return metadataPath(Util.VERSION_
BsoBird commented on code in PR #10623:
URL: https://github.com/apache/iceberg/pull/10623#discussion_r1669894107
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java:
##
@@ -291,137 +407,171 @@ Path versionHintFile() {
return metadataPath(Util.VERSION_
BsoBird commented on code in PR #10623:
URL: https://github.com/apache/iceberg/pull/10623#discussion_r1669891564
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java:
##
@@ -291,137 +407,171 @@ Path versionHintFile() {
return metadataPath(Util.VERSION_
BsoBird commented on code in PR #10623:
URL: https://github.com/apache/iceberg/pull/10623#discussion_r1669885260
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java:
##
@@ -291,137 +407,171 @@ Path versionHintFile() {
return metadataPath(Util.VERSION_
BsoBird commented on code in PR #10623:
URL: https://github.com/apache/iceberg/pull/10623#discussion_r1669877984
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java:
##
@@ -159,18 +169,124 @@ public void commit(TableMetadata base, TableMetadata
metadata)
BsoBird commented on code in PR #10623:
URL: https://github.com/apache/iceberg/pull/10623#discussion_r1669877984
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java:
##
@@ -159,18 +169,124 @@ public void commit(TableMetadata base, TableMetadata
metadata)
BsoBird commented on code in PR #10623:
URL: https://github.com/apache/iceberg/pull/10623#discussion_r1669872553
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java:
##
@@ -159,18 +169,124 @@ public void commit(TableMetadata base, TableMetadata
metadata)
BsoBird commented on code in PR #10623:
URL: https://github.com/apache/iceberg/pull/10623#discussion_r1669870050
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java:
##
@@ -159,18 +169,124 @@ public void commit(TableMetadata base, TableMetadata
metadata)
BsoBird commented on code in PR #10623:
URL: https://github.com/apache/iceberg/pull/10623#discussion_r1669866534
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java:
##
@@ -159,18 +169,124 @@ public void commit(TableMetadata base, TableMetadata
metadata)
BsoBird commented on code in PR #10623:
URL: https://github.com/apache/iceberg/pull/10623#discussion_r1669863261
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java:
##
@@ -159,18 +169,124 @@ public void commit(TableMetadata base, TableMetadata
metadata)
BsoBird commented on PR #10623:
URL: https://github.com/apache/iceberg/pull/10623#issuecomment-2207862734
@nastra @Fokko @RussellSpitzer @rdblue @pvary hello. If someone could help
me review this PR, that would be great. Tks.
--
This is an automated message from the Apache Git Service.
BsoBird opened a new pull request, #10623:
URL: https://github.com/apache/iceberg/pull/10623
# Refactor the code of HadoopTableOptions
## 1.Current problems
### 1.1.Enabling `write.metadata.delete-after-commit.enabled` may result in
dirty commits.
Since this option is tu
22 matches
Mail list logo
