Re: [PR] ci: add rust-cache action [iceberg-rust]

2024-12-27 Thread via GitHub
Xuanwo merged PR #844: URL: https://github.com/apache/iceberg-rust/pull/844 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.a

Re: [PR] ci: add rust-cache action [iceberg-rust]

2024-12-26 Thread via GitHub
xxchan commented on PR #844: URL: https://github.com/apache/iceberg-rust/pull/844#issuecomment-2562918365 Done: #851 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] ci: add rust-cache action [iceberg-rust]

2024-12-26 Thread via GitHub
Xuanwo commented on PR #844: URL: https://github.com/apache/iceberg-rust/pull/844#issuecomment-2562912761 Hi, as mentioned in https://github.com/apache/iceberg-rust/pull/849#issuecomment-2562904637, I'm fine with checking in `Cargo.lock`. Would you like to split this PR into two? One for c

Re: [PR] ci: add rust-cache action [iceberg-rust]

2024-12-24 Thread via GitHub
xxchan commented on PR #844: URL: https://github.com/apache/iceberg-rust/pull/844#issuecomment-2561687501 https://github.com/user-attachments/assets/4caf3b6f-41cb-44cf-980d-5b4e527fd3bd"; /> It performs much better than sccache (https://github.com/apache/iceberg-rust/pull/824#issueco