lidavidm commented on PR #125:
URL: https://github.com/apache/iceberg-cpp/pull/125#issuecomment-2991357437
MSVC tends to be oddly finicky but it's probably worth fixing those
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
zhjwpku commented on PR #125:
URL: https://github.com/apache/iceberg-cpp/pull/125#issuecomment-2991229731
Oops, it found a few more warnings on windows platform. Do you think it’s
worth addressing these? @wgtmac @lidavidm
https://github.com/apache/iceberg-cpp/actions/runs/1577784143
zhjwpku commented on PR #125:
URL: https://github.com/apache/iceberg-cpp/pull/125#issuecomment-2991116411
I checked the gh actions prior to #119, the logs say our builds contained
warnings (see [1]).
To prevent introducing additional warnings in the future, I propose to
enable compile w
zhjwpku opened a new pull request, #125:
URL: https://github.com/apache/iceberg-cpp/pull/125
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-