Fokko commented on PR #95:
URL: https://github.com/apache/iceberg-cpp/pull/95#issuecomment-2871531718
Thanks for working on this @zhjwpku, and thanks @lidavidm and @wgtmac for
the quick review 🙌
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
Fokko merged PR #95:
URL: https://github.com/apache/iceberg-cpp/pull/95
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach
zhjwpku commented on code in PR #95:
URL: https://github.com/apache/iceberg-cpp/pull/95#discussion_r2083671354
##
src/iceberg/json_internal.cc:
##
@@ -1210,11 +1216,11 @@ Result>
TableMetadataFromJson(const nlohmann::jso
}
Result FromJsonString(const std::string& json_strin
zhjwpku commented on code in PR #95:
URL: https://github.com/apache/iceberg-cpp/pull/95#discussion_r2083671213
##
src/iceberg/json_internal.cc:
##
@@ -173,12 +171,17 @@ void SetOptionalField(nlohmann::json& json,
std::string_view key,
}
}
+std::string DumpJsonNoExcept(con
wgtmac commented on code in PR #95:
URL: https://github.com/apache/iceberg-cpp/pull/95#discussion_r2083558800
##
src/iceberg/json_internal.cc:
##
@@ -1210,11 +1216,11 @@ Result>
TableMetadataFromJson(const nlohmann::jso
}
Result FromJsonString(const std::string& json_string
zhjwpku opened a new pull request, #95:
URL: https://github.com/apache/iceberg-cpp/pull/95
1. switch off exceptions for nlohmann::json::parse
2. add a no except wrapper around json.dump, since we don't handle
exceptions in Error messages.
This closes issue #87
References
