Re: [PR] chore: Bump to version 0.3.0 [iceberg-rust]

2024-03-05 Thread via GitHub
Fokko commented on PR #212: URL: https://github.com/apache/iceberg-rust/pull/212#issuecomment-1978207118 I'll close this for now. In Java/Python world it is typical to bump the version after the release. Maybe we should create consensus on bumping versions first. -- This is an automated

Re: [PR] chore: Bump to version 0.3.0 [iceberg-rust]

2024-03-05 Thread via GitHub
Fokko closed pull request #212: chore: Bump to version 0.3.0 URL: https://github.com/apache/iceberg-rust/pull/212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] chore: Bump to version 0.3.0 [iceberg-rust]

2024-02-21 Thread via GitHub
liurenjie1024 commented on PR #212: URL: https://github.com/apache/iceberg-rust/pull/212#issuecomment-1958476078 > As I mentioned before, we can decide the version to release in the discussion and bump version in a separate PR to initiate the release process. Sounds reasonable to me.

Re: [PR] chore: Bump to version 0.3.0 [iceberg-rust]

2024-02-21 Thread via GitHub
Xuanwo commented on PR #212: URL: https://github.com/apache/iceberg-rust/pull/212#issuecomment-1956531739 > cc @Xuanwo Any other concerns? I'm ok with this PR content but not its timing. As I mentioned before, we can decide the version to release in the discussion and bump vers

Re: [PR] chore: Bump to version 0.3.0 [iceberg-rust]

2024-02-21 Thread via GitHub
liurenjie1024 commented on PR #212: URL: https://github.com/apache/iceberg-rust/pull/212#issuecomment-1956510889 cc @Xuanwo Any other concerns? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] chore: Bump to version 0.3.0 [iceberg-rust]

2024-02-20 Thread via GitHub
liurenjie1024 commented on PR #212: URL: https://github.com/apache/iceberg-rust/pull/212#issuecomment-1955958747 > What we do at Python/Java, is create a branch for each major/minor version. If there are any bugs then we can backport them to the branch, and do a quick release. This way you

Re: [PR] chore: Bump to version 0.3.0 [iceberg-rust]

2024-02-20 Thread via GitHub
liurenjie1024 commented on PR #212: URL: https://github.com/apache/iceberg-rust/pull/212#issuecomment-1955956400 > > Upgrading minor version means add new features without breaking change, e.g. 0.2.0 -> 0.3.0. > > This is a breaking change in semver definition. I took a look at

Re: [PR] chore: Bump to version 0.3.0 [iceberg-rust]

2024-02-20 Thread via GitHub
Xuanwo commented on PR #212: URL: https://github.com/apache/iceberg-rust/pull/212#issuecomment-1954551404 Most rust packages just keep moving on next version and don't do backport and cherrypick. And considering our current state, it's less likely for us to maintaining a v0.2 branch 🫣 --

Re: [PR] chore: Bump to version 0.3.0 [iceberg-rust]

2024-02-20 Thread via GitHub
Fokko commented on PR #212: URL: https://github.com/apache/iceberg-rust/pull/212#issuecomment-1954392303 What we do at Python/Java, is create a branch for each major/minor version. If there are any bugs then we can backport them to the branch, and do a quick release. This way you don't have

Re: [PR] chore: Bump to version 0.3.0 [iceberg-rust]

2024-02-20 Thread via GitHub
Xuanwo commented on PR #212: URL: https://github.com/apache/iceberg-rust/pull/212#issuecomment-1954283514 > Upgrading minor version means add new features without breaking change, e.g. 0.2.0 -> 0.3.0. This is a breaking change in semver definition. -- This is an automated message f

Re: [PR] chore: Bump to version 0.3.0 [iceberg-rust]

2024-02-20 Thread via GitHub
liurenjie1024 commented on PR #212: URL: https://github.com/apache/iceberg-rust/pull/212#issuecomment-1954146668 > The difference lies in how we determine the version to release. > > Previously, we would decide on the version just before releasing it. This involved starting a discussi

Re: [PR] chore: Bump to version 0.3.0 [iceberg-rust]

2024-02-20 Thread via GitHub
Xuanwo commented on PR #212: URL: https://github.com/apache/iceberg-rust/pull/212#issuecomment-1954049870 The difference lies in how we determine the version to release. Previously, we would decide on the version just before releasing it. This involved starting a discussion on the mai

Re: [PR] chore: Bump to version 0.3.0 [iceberg-rust]

2024-02-20 Thread via GitHub
Xuanwo commented on PR #212: URL: https://github.com/apache/iceberg-rust/pull/212#issuecomment-1954046224 > LGTM, I think it's fine to upgrade it now. Ok, so we will always bump to next version during release? -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] chore: Bump to version 0.3.0 [iceberg-rust]

2024-02-20 Thread via GitHub
Xuanwo commented on PR #212: URL: https://github.com/apache/iceberg-rust/pull/212#issuecomment-1953904667 Should we bump the version just after releasing or before? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[PR] chore: Bump to version 0.3.0 [iceberg-rust]

2024-02-20 Thread via GitHub
Fokko opened a new pull request, #212: URL: https://github.com/apache/iceberg-rust/pull/212 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m