Re: [PR] allow override env-variables in load_catalog [iceberg-python]

2023-10-13 Thread via GitHub
Fokko merged PR #45: URL: https://github.com/apache/iceberg-python/pull/45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] allow override env-variables in load_catalog [iceberg-python]

2023-10-08 Thread via GitHub
Fokko commented on PR #45: URL: https://github.com/apache/iceberg-python/pull/45#issuecomment-1752165287 Thanks @bdilday for raising this, and I agree that the explicitly passed-in configuration should take preference. Can you rebase against the latest main branch? The CI should turn green

Re: [PR] allow override env-variables in load_catalog [iceberg-python]

2023-10-08 Thread via GitHub
rdblue commented on PR #45: URL: https://github.com/apache/iceberg-python/pull/45#issuecomment-1752161169 The proposed behavior sounds reasonable to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] allow override env-variables in load_catalog [iceberg-python]

2023-10-06 Thread via GitHub
bdilday opened a new pull request, #45: URL: https://github.com/apache/iceberg-python/pull/45 I found that I was unable to change a catalog URI after it had been configured by an environment variable. Example, ``` import os os.environ["PYICEBERG_CATALOG__SOMEDB__URI"] = "https: