Re: [PR] add scan tests with null values [iceberg-python]

2025-04-08 Thread via GitHub
Fokko commented on code in PR #1865: URL: https://github.com/apache/iceberg-python/pull/1865#discussion_r2033309802 ## tests/io/test_pyarrow.py: ## @@ -2317,3 +2321,66 @@ def test_pyarrow_io_multi_fs() -> None: # Same PyArrowFileIO instance resolves local file input t

Re: [PR] add scan tests with null values [iceberg-python]

2025-04-05 Thread via GitHub
Fokko commented on code in PR #1865: URL: https://github.com/apache/iceberg-python/pull/1865#discussion_r2021670570 ## tests/io/test_pyarrow.py: ## @@ -2317,3 +2321,66 @@ def test_pyarrow_io_multi_fs() -> None: # Same PyArrowFileIO instance resolves local file input t

Re: [PR] add scan tests with null values [iceberg-python]

2025-04-05 Thread via GitHub
Fokko commented on code in PR #1865: URL: https://github.com/apache/iceberg-python/pull/1865#discussion_r2024396389 ## tests/io/test_pyarrow.py: ## @@ -2317,3 +2321,66 @@ def test_pyarrow_io_multi_fs() -> None: # Same PyArrowFileIO instance resolves local file input t

Re: [PR] add scan tests with null values [iceberg-python]

2025-03-31 Thread via GitHub
Fokko commented on code in PR #1865: URL: https://github.com/apache/iceberg-python/pull/1865#discussion_r2021670570 ## tests/io/test_pyarrow.py: ## @@ -2317,3 +2321,66 @@ def test_pyarrow_io_multi_fs() -> None: # Same PyArrowFileIO instance resolves local file input t

Re: [PR] add scan tests with null values [iceberg-python]

2025-03-31 Thread via GitHub
kevinjqliu commented on code in PR #1865: URL: https://github.com/apache/iceberg-python/pull/1865#discussion_r2021466534 ## tests/io/test_pyarrow.py: ## @@ -2317,3 +2321,66 @@ def test_pyarrow_io_multi_fs() -> None: # Same PyArrowFileIO instance resolves local file in

Re: [PR] add scan tests with null values [iceberg-python]

2025-03-31 Thread via GitHub
kevinjqliu commented on code in PR #1865: URL: https://github.com/apache/iceberg-python/pull/1865#discussion_r2021453036 ## tests/io/test_pyarrow.py: ## @@ -2317,3 +2321,66 @@ def test_pyarrow_io_multi_fs() -> None: # Same PyArrowFileIO instance resolves local file in

Re: [PR] add scan tests with null values [iceberg-python]

2025-03-31 Thread via GitHub
kevinjqliu commented on code in PR #1865: URL: https://github.com/apache/iceberg-python/pull/1865#discussion_r2021452599 ## tests/io/test_pyarrow.py: ## @@ -2317,3 +2321,66 @@ def test_pyarrow_io_multi_fs() -> None: # Same PyArrowFileIO instance resolves local file in

[PR] add scan tests with null values [iceberg-python]

2025-03-31 Thread via GitHub
kevinjqliu opened a new pull request, #1865: URL: https://github.com/apache/iceberg-python/pull/1865 # Rationale for this change Test scan with null values Similar to https://github.com/apache/iceberg-rust/pull/1045 # Are these changes tested? # Ar