Re: [PR] add iceberg_avro interface [iceberg-cpp]

Fokko merged PR #34: URL: https://github.com/apache/iceberg-cpp/pull/34 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

Re: [PR] add iceberg_avro interface [iceberg-cpp]

wgtmac commented on code in PR #34: URL: https://github.com/apache/iceberg-cpp/pull/34#discussion_r1928502982 ## ci/scripts/build_example.sh: ## @@ -25,10 +25,27 @@ build_dir=${1}/build mkdir ${build_dir} pushd ${build_dir} -cmake \ --DCMAKE_PREFIX_PATH=${CMAKE_INSTALL_P

Re: [PR] add iceberg_avro interface [iceberg-cpp]

raulcd commented on code in PR #34: URL: https://github.com/apache/iceberg-cpp/pull/34#discussion_r1928409957 ## cmake_modules/IcebergThirdpartyToolchain.cmake: ## @@ -126,3 +126,77 @@ endfunction() if(ICEBERG_ARROW) resolve_arrow_dependency() endif() + +# -

Re: [PR] add iceberg_avro interface [iceberg-cpp]

wgtmac commented on PR #34: URL: https://github.com/apache/iceberg-cpp/pull/34#issuecomment-2612108480 I think this is ready to merge @Xuanwo @Fokko -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] add iceberg_avro interface [iceberg-cpp]

zhjwpku commented on PR #34: URL: https://github.com/apache/iceberg-cpp/pull/34#issuecomment-2611302409 > I have created a PR against your repo: [zhjwpku#3](https://github.com/zhjwpku/iceberg-cpp/pull/3). The CIs are all green on my side: [wgtmac#2](https://github.com/wgtmac/iceberg-cpp/pul

Re: [PR] add iceberg_avro interface [iceberg-cpp]

wgtmac commented on PR #34: URL: https://github.com/apache/iceberg-cpp/pull/34#issuecomment-2611262437 I have created a PR against your repo: https://github.com/zhjwpku/iceberg-cpp/pull/3. The CIs are all green on my side: https://github.com/wgtmac/iceberg-cpp/pull/2. Please take a look and

Re: [PR] add iceberg_avro interface [iceberg-cpp]

wgtmac commented on code in PR #34: URL: https://github.com/apache/iceberg-cpp/pull/34#discussion_r1925539978 ## cmake_modules/IcebergThirdpartyToolchain.cmake: ## @@ -126,3 +126,68 @@ endfunction() if(ICEBERG_ARROW) resolve_arrow_dependency() endif() + +# -

Re: [PR] add iceberg_avro interface [iceberg-cpp]

zhjwpku commented on code in PR #34: URL: https://github.com/apache/iceberg-cpp/pull/34#discussion_r1923958345 ## cmake_modules/IcebergThirdpartyToolchain.cmake: ## @@ -126,3 +126,68 @@ endfunction() if(ICEBERG_ARROW) resolve_arrow_dependency() endif() + +#

Re: [PR] add iceberg_avro interface [iceberg-cpp]

zhjwpku commented on code in PR #34: URL: https://github.com/apache/iceberg-cpp/pull/34#discussion_r1923958345 ## cmake_modules/IcebergThirdpartyToolchain.cmake: ## @@ -126,3 +126,68 @@ endfunction() if(ICEBERG_ARROW) resolve_arrow_dependency() endif() + +#

Re: [PR] add iceberg_avro interface [iceberg-cpp]

wgtmac commented on code in PR #34: URL: https://github.com/apache/iceberg-cpp/pull/34#discussion_r1923919166 ## cmake_modules/IcebergThirdpartyToolchain.cmake: ## @@ -126,3 +126,68 @@ endfunction() if(ICEBERG_ARROW) resolve_arrow_dependency() endif() + +# -

Re: [PR] add iceberg_avro interface [iceberg-cpp]

wgtmac commented on code in PR #34: URL: https://github.com/apache/iceberg-cpp/pull/34#discussion_r1923776627 ## src/iceberg/CMakeLists.txt: ## @@ -17,11 +17,16 @@ set(ICEBERG_SOURCES demo_table.cc) +set(ICEBERG_AVRO_STATIC_BUILD_LIBS) +list(APPEND ICEBERG_AVRO_STATIC_BUILD

Re: [PR] add iceberg_avro interface [iceberg-cpp]

zhjwpku commented on code in PR #34: URL: https://github.com/apache/iceberg-cpp/pull/34#discussion_r1923724860 ## src/iceberg/CMakeLists.txt: ## @@ -17,11 +17,16 @@ set(ICEBERG_SOURCES demo_table.cc) +set(ICEBERG_AVRO_STATIC_BUILD_LIBS) +list(APPEND ICEBERG_AVRO_STATIC_BUIL