Re: [PR] WIP: don't reset snapshotLog when replacing table [iceberg]

2024-02-16 Thread via GitHub
rdblue commented on code in PR #9732: URL: https://github.com/apache/iceberg/pull/9732#discussion_r1492829614 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -1246,7 +1246,6 @@ public Builder setRef(String name, SnapshotRef ref) { public Builder removeRef

Re: [PR] WIP: don't reset snapshotLog when replacing table [iceberg]

2024-02-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #9732: URL: https://github.com/apache/iceberg/pull/9732#discussion_r1492738591 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -1246,7 +1246,6 @@ public Builder setRef(String name, SnapshotRef ref) { public Builder

Re: [PR] WIP: don't reset snapshotLog when replacing table [iceberg]

2024-02-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #9732: URL: https://github.com/apache/iceberg/pull/9732#discussion_r1492738591 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -1246,7 +1246,6 @@ public Builder setRef(String name, SnapshotRef ref) { public Builder