Re: [PR] WIP: View Spec implementation [iceberg-rust]

2024-04-18 Thread via GitHub
c-thiel commented on PR #331: URL: https://github.com/apache/iceberg-rust/pull/331#issuecomment-2063797958 @Fokko thats is a hard topic. The idealist in me would like to eventually see something like substrait beeing used. Adoption of the project is very slow across engines though.

Re: [PR] WIP: View Spec implementation [iceberg-rust]

2024-04-15 Thread via GitHub
Fokko commented on PR #331: URL: https://github.com/apache/iceberg-rust/pull/331#issuecomment-2056308609 Thanks for working on this @c-thiel. Out of curiosity, and probably this is a broader discussion, but currently, the view spec is around [SQL representation](https://iceberg.apache.org/

Re: [PR] WIP: View Spec implementation [iceberg-rust]

2024-04-12 Thread via GitHub
c-thiel commented on PR #331: URL: https://github.com/apache/iceberg-rust/pull/331#issuecomment-2051874491 @ZENOTME one feature I did not implement yet is respecting "version.history.num-entries" as mentioned in the [View Spec](https://iceberg.apache.org/view-spec/#view-metadata). I noticed

Re: [PR] WIP: View Spec implementation [iceberg-rust]

2024-04-11 Thread via GitHub
c-thiel commented on code in PR #331: URL: https://github.com/apache/iceberg-rust/pull/331#discussion_r1562077154 ## crates/iceberg/src/catalog/mod.rs: ## @@ -438,6 +438,31 @@ impl TableUpdate { } } +/// TableCreation represents the creation of a table in the catalog. R

Re: [PR] WIP: View Spec implementation [iceberg-rust]

2024-04-11 Thread via GitHub
ZENOTME commented on PR #331: URL: https://github.com/apache/iceberg-rust/pull/331#issuecomment-2049849148 Thanks! Nice work! @c-thiel -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] WIP: View Spec implementation [iceberg-rust]

2024-04-11 Thread via GitHub
ZENOTME commented on code in PR #331: URL: https://github.com/apache/iceberg-rust/pull/331#discussion_r1561132461 ## crates/iceberg/src/catalog/mod.rs: ## @@ -438,6 +438,31 @@ impl TableUpdate { } } +/// TableCreation represents the creation of a table in the catalog. R