Re: [PR] WIP: Use localhost instead of container hostname [iceberg-rust]

2024-12-09 Thread via GitHub
Fokko closed pull request #748: WIP: Use localhost instead of container hostname URL: https://github.com/apache/iceberg-rust/pull/748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] WIP: Use localhost instead of container hostname [iceberg-rust]

2024-12-09 Thread via GitHub
Fokko commented on PR #748: URL: https://github.com/apache/iceberg-rust/pull/748#issuecomment-2528000595 I've switched to Orbstack and it works pretty well :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] WIP: Use localhost instead of container hostname [iceberg-rust]

2024-12-09 Thread via GitHub
liurenjie1024 commented on PR #748: URL: https://github.com/apache/iceberg-rust/pull/748#issuecomment-2527493973 Hi, @Fokko @ZENOTME helped to did some investigation and found that the reason we can't use current approach is a known limitation: https://docs.docker.com/desktop/features/netw

Re: [PR] WIP: Use localhost instead of container hostname [iceberg-rust]

2024-12-06 Thread via GitHub
nastra commented on PR #748: URL: https://github.com/apache/iceberg-rust/pull/748#issuecomment-2523569678 @Fokko you're not alone. Those tests fail for me too using native Docker on OSX due to networking: ``` test tests::gcs_exists has been running for over 60 seconds test tests

Re: [PR] WIP: Use localhost instead of container hostname [iceberg-rust]

2024-12-06 Thread via GitHub
Fokko commented on PR #748: URL: https://github.com/apache/iceberg-rust/pull/748#issuecomment-2522526691 @liurenjie1024 Ah, yes, that would be one of the drawbacks @nastra Asking for a favor. Could you clone this repository, and try to run `make test`? I wanted to check if I'm the onl

Re: [PR] WIP: Use localhost instead of container hostname [iceberg-rust]

2024-12-04 Thread via GitHub
Fokko commented on PR #748: URL: https://github.com/apache/iceberg-rust/pull/748#issuecomment-2517282424 @liurenjie1024 unfortunately yes, the `172.*` IPs that the library return don't work on my end. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] WIP: Use localhost instead of container hostname [iceberg-rust]

2024-12-03 Thread via GitHub
liurenjie1024 commented on PR #748: URL: https://github.com/apache/iceberg-rust/pull/748#issuecomment-2516087345 cc @Fokko Do we still this change? I see your comment https://github.com/apache/iceberg-rust/issues/719#issuecomment-2511739559 here. -- This is an automated message from the A

[PR] WIP: Use localhost instead of container hostname [iceberg-rust]

2024-12-01 Thread via GitHub
Fokko opened a new pull request, #748: URL: https://github.com/apache/iceberg-rust/pull/748 To see if I can run this locally as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c