Re: [PR] WIP: TableMetadataBuilder [iceberg-rust]

2024-09-02 Thread via GitHub
c-thiel commented on PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#issuecomment-2325737930 Fixes https://github.com/apache/iceberg-rust/issues/232 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] WIP: TableMetadataBuilder [iceberg-rust]

2024-08-30 Thread via GitHub
c-thiel commented on PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#issuecomment-2320930388 ToDos: - [x] First PR as discussion basis - [ ] Reserved Property handling - [ ] Finish discussion about `SortOrder` and `PartitionSpec` re-binding - [ ] Review from 1-2 Java

Re: [PR] WIP: TableMetadataBuilder [iceberg-rust]

2024-08-26 Thread via GitHub
c-thiel commented on PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#issuecomment-2310855076 @nastra if you have a bit of time, it would be great to get some early feedback on the `add_schema` method (https://github.com/apache/iceberg-rust/pull/587/files#diff-464f76c3b76da4149

[PR] WIP: TableMetadataBuilder [iceberg-rust]

2024-08-26 Thread via GitHub
c-thiel opened a new pull request, #587: URL: https://github.com/apache/iceberg-rust/pull/587 This branch is currently WIP. I am using it as a place for while developing the `TableMetadataBuilder`. -- This is an automated message from the Apache Git Service. To respond to the message,