Re: [PR] WIP: Glue catalog commit [iceberg-python]

2023-12-14 Thread via GitHub
HonahX commented on code in PR #140: URL: https://github.com/apache/iceberg-python/pull/140#discussion_r1427597141 ## pyiceberg/catalog/glue.py: ## @@ -59,21 +61,33 @@ from pyiceberg.partitioning import UNPARTITIONED_PARTITION_SPEC, PartitionSpec from pyiceberg.schema import S

Re: [PR] WIP: Glue catalog commit [iceberg-python]

2023-12-14 Thread via GitHub
jackye1995 commented on code in PR #140: URL: https://github.com/apache/iceberg-python/pull/140#discussion_r1427178174 ## pyiceberg/catalog/glue.py: ## @@ -59,21 +61,33 @@ from pyiceberg.partitioning import UNPARTITIONED_PARTITION_SPEC, PartitionSpec from pyiceberg.schema impo

Re: [PR] WIP: Glue catalog commit [iceberg-python]

2023-12-14 Thread via GitHub
nicor88 commented on code in PR #140: URL: https://github.com/apache/iceberg-python/pull/140#discussion_r1426413605 ## pyiceberg/catalog/glue.py: ## @@ -177,6 +191,23 @@ def _create_glue_table(self, database_name: str, table_name: str, table_input: T except self.glue.e

Re: [PR] WIP: Glue catalog commit [iceberg-python]

2023-12-14 Thread via GitHub
nicor88 commented on code in PR #140: URL: https://github.com/apache/iceberg-python/pull/140#discussion_r1426412419 ## pyiceberg/catalog/glue.py: ## @@ -247,8 +278,50 @@ def _commit_table(self, table_request: CommitTableRequest) -> CommitTableRespons Raises:

Re: [PR] WIP: Glue catalog commit [iceberg-python]

2023-12-13 Thread via GitHub
HonahX commented on PR #140: URL: https://github.com/apache/iceberg-python/pull/140#issuecomment-1855276027 I'm quite busy at the moment, but I'm aiming to complete this by the end of the week. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] WIP: Glue catalog commit [iceberg-python]

2023-12-13 Thread via GitHub
HonahX commented on code in PR #140: URL: https://github.com/apache/iceberg-python/pull/140#discussion_r1426255789 ## pyiceberg/catalog/glue.py: ## @@ -247,8 +278,50 @@ def _commit_table(self, table_request: CommitTableRequest) -> CommitTableRespons Raises:

Re: [PR] WIP: Glue catalog commit [iceberg-python]

2023-12-13 Thread via GitHub
HonahX commented on code in PR #140: URL: https://github.com/apache/iceberg-python/pull/140#discussion_r1426255789 ## pyiceberg/catalog/glue.py: ## @@ -247,8 +278,50 @@ def _commit_table(self, table_request: CommitTableRequest) -> CommitTableRespons Raises:

Re: [PR] WIP: Glue catalog commit [iceberg-python]

2023-12-13 Thread via GitHub
HonahX commented on code in PR #140: URL: https://github.com/apache/iceberg-python/pull/140#discussion_r1426255789 ## pyiceberg/catalog/glue.py: ## @@ -247,8 +278,50 @@ def _commit_table(self, table_request: CommitTableRequest) -> CommitTableRespons Raises:

Re: [PR] WIP: Glue catalog commit [iceberg-python]

2023-12-13 Thread via GitHub
HonahX commented on code in PR #140: URL: https://github.com/apache/iceberg-python/pull/140#discussion_r1426238613 ## pyiceberg/catalog/glue.py: ## @@ -177,6 +191,23 @@ def _create_glue_table(self, database_name: str, table_name: str, table_input: T except self.glue.ex

Re: [PR] WIP: Glue catalog commit [iceberg-python]

2023-12-12 Thread via GitHub
nicor88 commented on code in PR #140: URL: https://github.com/apache/iceberg-python/pull/140#discussion_r1423664192 ## pyiceberg/catalog/glue.py: ## @@ -247,8 +278,50 @@ def _commit_table(self, table_request: CommitTableRequest) -> CommitTableRespons Raises:

Re: [PR] WIP: Glue catalog commit [iceberg-python]

2023-12-12 Thread via GitHub
nicor88 commented on code in PR #140: URL: https://github.com/apache/iceberg-python/pull/140#discussion_r1423664192 ## pyiceberg/catalog/glue.py: ## @@ -247,8 +278,50 @@ def _commit_table(self, table_request: CommitTableRequest) -> CommitTableRespons Raises:

Re: [PR] WIP: Glue catalog commit [iceberg-python]

2023-12-12 Thread via GitHub
nicor88 commented on code in PR #140: URL: https://github.com/apache/iceberg-python/pull/140#discussion_r1423647501 ## pyiceberg/catalog/glue.py: ## @@ -177,6 +191,23 @@ def _create_glue_table(self, database_name: str, table_name: str, table_input: T except self.glue.e

Re: [PR] WIP: Glue catalog commit [iceberg-python]

2023-12-12 Thread via GitHub
nicor88 commented on code in PR #140: URL: https://github.com/apache/iceberg-python/pull/140#discussion_r1423647501 ## pyiceberg/catalog/glue.py: ## @@ -177,6 +191,23 @@ def _create_glue_table(self, database_name: str, table_name: str, table_input: T except self.glue.e