Re: [PR] Use version-hint.text for StaticTable [iceberg-python]

2025-04-17 Thread via GitHub
Fokko merged PR #1887: URL: https://github.com/apache/iceberg-python/pull/1887 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] Use version-hint.text for StaticTable [iceberg-python]

2025-04-16 Thread via GitHub
arnaudbriche commented on PR #1887: URL: https://github.com/apache/iceberg-python/pull/1887#issuecomment-2809793585 Hi @Fokko I have version `3.13.2` installed. Anyway, I used the Docker image as proposed, and tests execution worked. I added a small one for this feature, and add

[PR] Use version-hint.text for StaticTable [iceberg-python]

2025-04-10 Thread via GitHub
arnaudbriche opened a new pull request, #1887: URL: https://github.com/apache/iceberg-python/pull/1887 This change allow making use of the `version-hint.text` file when a static table is instantiated with a `metadata_location` not ending with '.metadata.json'. User can just point to the

Re: [PR] Use version-hint.text for StaticTable [iceberg-python]

2025-04-09 Thread via GitHub
Fokko commented on PR #1887: URL: https://github.com/apache/iceberg-python/pull/1887#issuecomment-2791104936 Hey @arnaudbriche OSX should work fine (using it myself). We vendor the `hive_metastore` modules, so I'm not sure what's going on there. Which Python version are you using? Do you ha

Re: [PR] Use version-hint.text for StaticTable [iceberg-python]

2025-04-09 Thread via GitHub
arnaudbriche commented on PR #1887: URL: https://github.com/apache/iceberg-python/pull/1887#issuecomment-2789910347 Hi @Fokko , Do you know if running the test suite on OSX is supported ? Or should I switch to working from a Linux box ? -- This is an automated message from the Apac

Re: [PR] Use version-hint.text for StaticTable [iceberg-python]

2025-04-08 Thread via GitHub
arnaudbriche commented on PR #1887: URL: https://github.com/apache/iceberg-python/pull/1887#issuecomment-2786677593 And now: ```sh PYTHONPATH=".:$PYTHONPATH" make test poetry run pytest tests/ -m "(unmarked or parametrize) and not integration"

Re: [PR] Use version-hint.text for StaticTable [iceberg-python]

2025-04-08 Thread via GitHub
arnaudbriche commented on PR #1887: URL: https://github.com/apache/iceberg-python/pull/1887#issuecomment-2786613375 > @arnaudbriche That's no problem. Can you try: > > ```shell > make install > make test > ``` > > We use a `Makefile` to run the correct commands.

Re: [PR] Use version-hint.text for StaticTable [iceberg-python]

2025-04-08 Thread via GitHub
arnaudbriche commented on PR #1887: URL: https://github.com/apache/iceberg-python/pull/1887#issuecomment-2786672312 Ok so I installed the right poetry version by hand. But now, while trying to run the tests, I get: ```sh make test poetry run pytest tests/ -m "(unmarked or

Re: [PR] Use version-hint.text for StaticTable [iceberg-python]

2025-04-08 Thread via GitHub
Fokko commented on PR #1887: URL: https://github.com/apache/iceberg-python/pull/1887#issuecomment-2786361016 @arnaudbriche That's no problem. Can you try: ```sh make install make test ``` We use a `Makefile` to run the correct commands. -- This is an automated messag

Re: [PR] Use version-hint.text for StaticTable [iceberg-python]

2025-04-08 Thread via GitHub
arnaudbriche commented on PR #1887: URL: https://github.com/apache/iceberg-python/pull/1887#issuecomment-2785902292 > Thanks for raising this @arnaudbriche 🙌 > > How would you feel about: > > * Adding a test to make sure that this works, and we don't break it in the future >