Re: [PR] Use a join for upsert deduplication [iceberg-python]

2025-02-21 Thread via GitHub
Fokko commented on code in PR #1685: URL: https://github.com/apache/iceberg-python/pull/1685#discussion_r1965766188 ## pyiceberg/table/upsert_util.py: ## @@ -53,42 +53,18 @@ def get_rows_to_update(source_table: pa.Table, target_table: pa.Table, join_cols """ all_colum

Re: [PR] Use a join for upsert deduplication [iceberg-python]

2025-02-21 Thread via GitHub
kevinjqliu merged PR #1685: URL: https://github.com/apache/iceberg-python/pull/1685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@i

Re: [PR] Use a join for upsert deduplication [iceberg-python]

2025-02-21 Thread via GitHub
Fokko commented on code in PR #1685: URL: https://github.com/apache/iceberg-python/pull/1685#discussion_r1965782385 ## pyiceberg/table/upsert_util.py: ## @@ -53,42 +53,18 @@ def get_rows_to_update(source_table: pa.Table, target_table: pa.Table, join_cols """ all_colum

Re: [PR] Use a join for upsert deduplication [iceberg-python]

2025-02-21 Thread via GitHub
Fokko commented on code in PR #1685: URL: https://github.com/apache/iceberg-python/pull/1685#discussion_r1965786729 ## pyiceberg/table/upsert_util.py: ## @@ -53,42 +53,18 @@ def get_rows_to_update(source_table: pa.Table, target_table: pa.Table, join_cols """ Review Commen

Re: [PR] Use a join for upsert deduplication [iceberg-python]

2025-02-21 Thread via GitHub
Fokko commented on code in PR #1685: URL: https://github.com/apache/iceberg-python/pull/1685#discussion_r1965780238 ## pyiceberg/table/upsert_util.py: ## @@ -53,42 +53,18 @@ def get_rows_to_update(source_table: pa.Table, target_table: pa.Table, join_cols """ all_colum

Re: [PR] Use a join for upsert deduplication [iceberg-python]

2025-02-20 Thread via GitHub
kevinjqliu commented on code in PR #1685: URL: https://github.com/apache/iceberg-python/pull/1685#discussion_r1963933055 ## pyiceberg/table/upsert_util.py: ## @@ -53,42 +53,18 @@ def get_rows_to_update(source_table: pa.Table, target_table: pa.Table, join_cols """ all_