Re: [PR] Use `VisitorWithPartner` for name-mapping [iceberg-python]

2024-08-13 Thread via GitHub
sungwy merged PR #1014: URL: https://github.com/apache/iceberg-python/pull/1014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@icebe

Re: [PR] Use `VisitorWithPartner` for name-mapping [iceberg-python]

2024-08-08 Thread via GitHub
Fokko commented on code in PR #1014: URL: https://github.com/apache/iceberg-python/pull/1014#discussion_r1708963604 ## pyiceberg/table/name_mapping.py: ## @@ -248,3 +254,127 @@ def create_mapping_from_schema(schema: Schema) -> NameMapping: def update_mapping(mapping: NameMap

Re: [PR] Use `VisitorWithPartner` for name-mapping [iceberg-python]

2024-08-08 Thread via GitHub
Fokko commented on code in PR #1014: URL: https://github.com/apache/iceberg-python/pull/1014#discussion_r1708957678 ## pyiceberg/table/name_mapping.py: ## @@ -74,6 +75,11 @@ class NameMapping(IcebergRootModel[List[MappedField]]): def _field_by_name(self) -> Dict[str, Mapped

Re: [PR] Use `VisitorWithPartner` for name-mapping [iceberg-python]

2024-08-07 Thread via GitHub
sungwy commented on code in PR #1014: URL: https://github.com/apache/iceberg-python/pull/1014#discussion_r1706931818 ## pyiceberg/table/name_mapping.py: ## @@ -74,6 +75,11 @@ class NameMapping(IcebergRootModel[List[MappedField]]): def _field_by_name(self) -> Dict[str, Mappe

[PR] Use `VisitorWithPartner` for name-mapping [iceberg-python]

2024-08-07 Thread via GitHub
Fokko opened a new pull request, #1014: URL: https://github.com/apache/iceberg-python/pull/1014 This will correctly handle fields with `.` in the name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g