kevinjqliu merged PR #1371:
URL: https://github.com/apache/iceberg-python/pull/1371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@i
Fokko commented on PR #1371:
URL: https://github.com/apache/iceberg-python/pull/1371#issuecomment-2501851589
@kevinjqliu Ah I see, I don't think that we have _fully_ reproducible
builds. For example, if a timestamp in some wheel is different, then it would
yield another hash. I think it is
kevinjqliu commented on PR #1371:
URL: https://github.com/apache/iceberg-python/pull/1371#issuecomment-2501640410
I was comparing between running the action on
[main](https://github.com/kevinjqliu/iceberg-python/actions/runs/12036359688)
versus [this
branch](https://github.com/kevinjqliu/i
Fokko commented on code in PR #1371:
URL: https://github.com/apache/iceberg-python/pull/1371#discussion_r1858683932
##
.github/workflows/python-release.yml:
##
@@ -34,7 +34,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
-os: [ ubuntu-22.04, windo
Fokko commented on PR #1371:
URL: https://github.com/apache/iceberg-python/pull/1371#issuecomment-2501017013
@kevinjqliu Can you elaborate? I just pushed it to my own branch, and I see
identical hashes:
```
➜ Downloads shasum -a 512
release-ubuntu-22.04/pyiceberg-0.8.0-cp310-cp31
kevinjqliu commented on PR #1371:
URL: https://github.com/apache/iceberg-python/pull/1371#issuecomment-2499182778
@Fokko I double-checked the new artifacts, file names match but they have
different hashes.
--
This is an automated message from the Apache Git Service.
To respond to the mes
kevinjqliu commented on code in PR #1371:
URL: https://github.com/apache/iceberg-python/pull/1371#discussion_r1857407764
##
.github/workflows/python-release.yml:
##
@@ -34,7 +34,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
-os: [ ubuntu-22.04,
Fokko commented on code in PR #1371:
URL: https://github.com/apache/iceberg-python/pull/1371#discussion_r1857351157
##
.github/workflows/python-release.yml:
##
@@ -84,7 +84,16 @@ jobs:
if: startsWith(matrix.os, 'ubuntu')
run: ls -lah dist/* && cp dist/* wheelho
Fokko commented on PR #1371:
URL: https://github.com/apache/iceberg-python/pull/1371#issuecomment-2498948927
Thanks for bumping this, unfortunately, we've downgraded to `v3` a while ago
https://github.com/apache/iceberg-python/pull/396
With V4 it does not combine the zip files, so we
kevinjqliu opened a new pull request, #1371:
URL: https://github.com/apache/iceberg-python/pull/1371
Based on https://lists.apache.org/thread/nx19j3h61tjmsk8c8vx24gbq6ygf7pyf
`upload-artifact@v3` only used in iceberg-python
https://grep.app/search?q=actions/upload-artifact%40v3&fil
10 matches
Mail list logo
