Re: [PR] Tests: Unify the test catalog setting [iceberg-python]

2024-04-16 Thread via GitHub
HonahX merged PR #609: URL: https://github.com/apache/iceberg-python/pull/609 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Tests: Unify the test catalog setting [iceberg-python]

2024-04-16 Thread via GitHub
frankliee commented on code in PR #609: URL: https://github.com/apache/iceberg-python/pull/609#discussion_r1566818851 ## tests/conftest.py: ## @@ -2144,3 +2144,31 @@ def arrow_table_with_only_nulls(pa_schema: "pa.Schema") -> "pa.Table": import pyarrow as pa return p

Re: [PR] Tests: Unify the test catalog setting [iceberg-python]

2024-04-16 Thread via GitHub
frankliee commented on code in PR #609: URL: https://github.com/apache/iceberg-python/pull/609#discussion_r1566818851 ## tests/conftest.py: ## @@ -2144,3 +2144,31 @@ def arrow_table_with_only_nulls(pa_schema: "pa.Schema") -> "pa.Table": import pyarrow as pa return p

Re: [PR] Tests: Unify the test catalog setting [iceberg-python]

2024-04-16 Thread via GitHub
frankliee commented on code in PR #609: URL: https://github.com/apache/iceberg-python/pull/609#discussion_r1566818851 ## tests/conftest.py: ## @@ -2144,3 +2144,31 @@ def arrow_table_with_only_nulls(pa_schema: "pa.Schema") -> "pa.Table": import pyarrow as pa return p

Re: [PR] Tests: Unify the test catalog setting [iceberg-python]

2024-04-15 Thread via GitHub
frankliee commented on code in PR #609: URL: https://github.com/apache/iceberg-python/pull/609#discussion_r1566818851 ## tests/conftest.py: ## @@ -2144,3 +2144,31 @@ def arrow_table_with_only_nulls(pa_schema: "pa.Schema") -> "pa.Table": import pyarrow as pa return p

Re: [PR] Tests: Unify the test catalog setting [iceberg-python]

2024-04-15 Thread via GitHub
HonahX commented on code in PR #609: URL: https://github.com/apache/iceberg-python/pull/609#discussion_r1566772517 ## tests/conftest.py: ## @@ -2144,3 +2144,31 @@ def arrow_table_with_only_nulls(pa_schema: "pa.Schema") -> "pa.Table": import pyarrow as pa return pa.T