Re: [PR] Table Scan: Add Row Selection Filtering [iceberg-rust]

2024-09-24 Thread via GitHub
liurenjie1024 commented on code in PR #565: URL: https://github.com/apache/iceberg-rust/pull/565#discussion_r1772764549 ## crates/iceberg/src/expr/visitors/page_index_evaluator.rs: ## @@ -0,0 +1,1491 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

Re: [PR] Table Scan: Add Row Selection Filtering [iceberg-rust]

2024-09-24 Thread via GitHub
liurenjie1024 merged PR #565: URL: https://github.com/apache/iceberg-rust/pull/565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] Table Scan: Add Row Selection Filtering [iceberg-rust]

2024-09-05 Thread via GitHub
sdd commented on code in PR #565: URL: https://github.com/apache/iceberg-rust/pull/565#discussion_r1746597564 ## crates/iceberg/src/expr/visitors/page_index_evaluator.rs: ## @@ -0,0 +1,1491 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] Table Scan: Add Row Selection Filtering [iceberg-rust]

2024-09-05 Thread via GitHub
sdd commented on code in PR #565: URL: https://github.com/apache/iceberg-rust/pull/565#discussion_r1746573022 ## crates/iceberg/src/expr/visitors/page_index_evaluator.rs: ## @@ -0,0 +1,1491 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] Table Scan: Add Row Selection Filtering [iceberg-rust]

2024-09-03 Thread via GitHub
liurenjie1024 commented on code in PR #565: URL: https://github.com/apache/iceberg-rust/pull/565#discussion_r1742915490 ## crates/iceberg/src/expr/visitors/page_index_evaluator.rs: ## @@ -0,0 +1,1491 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

Re: [PR] Table Scan: Add Row Selection Filtering [iceberg-rust]

2024-09-03 Thread via GitHub
sdd commented on PR #565: URL: https://github.com/apache/iceberg-rust/pull/565#issuecomment-2326321589 @liurenjie1024 / @Xuanwo - PTAL when you get chance, thanks 👍🏼 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the