Re: [PR] Support Distinct Counts in Manifest [iceberg-python]

2025-03-04 Thread via GitHub
jpugliesi commented on PR #1613: URL: https://github.com/apache/iceberg-python/pull/1613#issuecomment-2698679289 All good, glad we've sorted this out. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] Support Distinct Counts in Manifest [iceberg-python]

2025-03-04 Thread via GitHub
Fokko commented on PR #1613: URL: https://github.com/apache/iceberg-python/pull/1613#issuecomment-2696694995 With the deprecation in https://github.com/apache/iceberg/pull/12182, I'm going to close this PR. Sorry for not being more transparent in this @jpugliesi -- This is an automated m

Re: [PR] Support Distinct Counts in Manifest [iceberg-python]

2025-03-04 Thread via GitHub
Fokko closed pull request #1613: Support Distinct Counts in Manifest URL: https://github.com/apache/iceberg-python/pull/1613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Support Distinct Counts in Manifest [iceberg-python]

2025-02-06 Thread via GitHub
Fokko commented on PR #1613: URL: https://github.com/apache/iceberg-python/pull/1613#issuecomment-2640210928 @jacobmarble I'm able to read both of them: ```python def test_starburst(): io = load_file_io() snapshot = Snapshot( snapshot_id=25, paren

Re: [PR] Support Distinct Counts in Manifest [iceberg-python]

2025-02-05 Thread via GitHub
jacobmarble commented on PR #1613: URL: https://github.com/apache/iceberg-python/pull/1613#issuecomment-2637585864 > It should just silently ignore the field and skip over it when reading. FWIW just yesterday I used PyIceberg to read some manifests generated by Starburst in feb-2024 (

Re: [PR] Support Distinct Counts in Manifest [iceberg-python]

2025-02-05 Thread via GitHub
Fokko commented on PR #1613: URL: https://github.com/apache/iceberg-python/pull/1613#issuecomment-2637529531 @jpugliesi I agree that it should be indicated in the spec, sorry about that. I was pretty convinced that it was marked as deprecated at some point. Let's follow up on https://github

Re: [PR] Support Distinct Counts in Manifest [iceberg-python]

2025-02-05 Thread via GitHub
jpugliesi commented on PR #1613: URL: https://github.com/apache/iceberg-python/pull/1613#issuecomment-2637488509 @Fokko ah thanks for pointing this out... I was just referencing the spec, [which does not indicate `distinct_counts` is deprecated](https://iceberg.apache.org/spec/#manifests).

Re: [PR] Support Distinct Counts in Manifest [iceberg-python]

2025-02-05 Thread via GitHub
Fokko commented on PR #1613: URL: https://github.com/apache/iceberg-python/pull/1613#issuecomment-2636837341 @jpugliesi Thanks for raising this. Unfortunally, the `distinct_counts` has been deprecated: https://github.com/apache/iceberg/issues/767 -- This is an automated message from the A

[PR] Support Distinct Counts in Manifest [iceberg-python]

2025-02-04 Thread via GitHub
jpugliesi opened a new pull request, #1613: URL: https://github.com/apache/iceberg-python/pull/1613 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr