Re: [PR] SqlCatalog, default create_engine echo to False [iceberg-python]

2024-02-04 Thread via GitHub
Fokko merged PR #360: URL: https://github.com/apache/iceberg-python/pull/360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] SqlCatalog, default create_engine echo to False [iceberg-python]

2024-02-04 Thread via GitHub
Fokko commented on code in PR #360: URL: https://github.com/apache/iceberg-python/pull/360#discussion_r1477434800 ## pyiceberg/catalog/sql.py: ## @@ -101,7 +101,8 @@ def __init__(self, name: str, **properties: str): if not (uri_prop := self.properties.get("uri")):

[PR] SqlCatalog, default create_engine echo to False [iceberg-python]

2024-02-03 Thread via GitHub
kevinjqliu opened a new pull request, #360: URL: https://github.com/apache/iceberg-python/pull/360 `create_engine`'s `echo` is useful for debugging purposes. Otherwise, it exposes a lot of internal SQLite information when it's not needed. ![Screenshot 2024-02-03 at 11 01 53