Re: [PR] Spec: Make NDV blob metadata property required [iceberg]

2024-11-14 Thread via GitHub
github-actions[bot] commented on PR #10549: URL: https://github.com/apache/iceberg/pull/10549#issuecomment-2477675322 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [PR] Spec: Make NDV blob metadata property required [iceberg]

2024-11-14 Thread via GitHub
github-actions[bot] closed pull request #10549: Spec: Make NDV blob metadata property required URL: https://github.com/apache/iceberg/pull/10549 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Spec: Make NDV blob metadata property required [iceberg]

2024-11-06 Thread via GitHub
github-actions[bot] commented on PR #10549: URL: https://github.com/apache/iceberg/pull/10549#issuecomment-2461061133 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Spec: Make NDV blob metadata property required [iceberg]

2024-07-05 Thread via GitHub
amogh-jahagirdar commented on PR #10549: URL: https://github.com/apache/iceberg/pull/10549#issuecomment-2211248500 @findepi I think I largely agree with you that a Puffin V2 is probably too broad for this since we're not even changing the metadata; we can granularly update the theta sketch

Re: [PR] Spec: Make NDV blob metadata property required [iceberg]

2024-07-05 Thread via GitHub
findepi commented on PR #10549: URL: https://github.com/apache/iceberg/pull/10549#issuecomment-2211167108 Puffin fole format has place for versioning within the magic, but the Puffin format doesn't change, only its use changes. Puffin spec is not authoritative source of information of all

Re: [PR] Spec: Make NDV blob metadata property required [iceberg]

2024-07-05 Thread via GitHub
amogh-jahagirdar commented on PR #10549: URL: https://github.com/apache/iceberg/pull/10549#issuecomment-2211066525 Hey everyone, sorry for the delay just want to make sure we're following the standard improvement proposal process here: 1.) https://iceberg.apache.org/contribute/#what-i

Re: [PR] Spec: Make NDV blob metadata property required [iceberg]

2024-07-05 Thread via GitHub
amogh-jahagirdar closed pull request #10549: Spec: Make NDV blob metadata property required URL: https://github.com/apache/iceberg/pull/10549 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Spec: Make NDV blob metadata property required [iceberg]

2024-06-22 Thread via GitHub
singhpk234 commented on PR #10549: URL: https://github.com/apache/iceberg/pull/10549#issuecomment-2183494450 sounds fair ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] Spec: Make NDV blob metadata property required [iceberg]

2024-06-22 Thread via GitHub
amogh-jahagirdar commented on PR #10549: URL: https://github.com/apache/iceberg/pull/10549#issuecomment-2183491829 > Should we make the properties section in the BlobMetadata now as mandatory as well as now this key i,e ndv would be present and hence properties I don't think so, since

Re: [PR] Spec: Make NDV blob metadata property required [iceberg]

2024-06-22 Thread via GitHub
amogh-jahagirdar commented on PR #10549: URL: https://github.com/apache/iceberg/pull/10549#issuecomment-2183483594 cc @szehon-ho @singhpk234 @karuppayya -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to