RussellSpitzer commented on PR #11067:
URL: https://github.com/apache/iceberg/pull/11067#issuecomment-2438751173
Thanks @ajantha-bhat and @danielcweeks , @rdblue , @manuzhang and
@amogh-jahagirdar for review
--
This is an automated message from the Apache Git Service.
To respond to the me
RussellSpitzer merged PR #11067:
URL: https://github.com/apache/iceberg/pull/11067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
ajantha-bhat commented on PR #11067:
URL: https://github.com/apache/iceberg/pull/11067#issuecomment-2436946836
@danielcweeks: Thanks for the review. Conflict was due to recent row-lineage
merge. I have resolved it now. PR is ready.
--
This is an automated message from the Apache Git Serv
danielcweeks commented on PR #11067:
URL: https://github.com/apache/iceberg/pull/11067#issuecomment-2436139576
@ajantha-bhat looks like we have conflicts. It would be good to get this
in, but I don't think this section of the docs is tied to the 1.7.0 release.
--
This is an automated mes
rdblue commented on code in PR #11067:
URL: https://github.com/apache/iceberg/pull/11067#discussion_r1807491293
##
format/spec.md:
##
@@ -158,27 +158,27 @@ Readers should be more permissive because v1 metadata
files are allowed in v2 ta
Readers may be more strict for metadat
rdblue commented on PR #11067:
URL: https://github.com/apache/iceberg/pull/11067#issuecomment-2424245333
I think this is fine. @danielcweeks is the organization what you want?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
ajantha-bhat commented on PR #11067:
URL: https://github.com/apache/iceberg/pull/11067#issuecomment-2415625928
@danielcweeks: Thanks for the feedback. I have updated it accordingly.
New TOC looks like this.
https://github.com/user-attachments/assets/bd43a672-d3aa-49a3-b643-2d
danielcweeks commented on PR #11067:
URL: https://github.com/apache/iceberg/pull/11067#issuecomment-2414890266
@ajantha-bhat I feel like this has bounced back and forth on the levels, but
we should be focused on getting the structure correct first and then addressing
the ToC. This current
danielcweeks commented on code in PR #11067:
URL: https://github.com/apache/iceberg/pull/11067#discussion_r1801822542
##
format/spec.md:
##
@@ -158,27 +158,27 @@ Readers should be more permissive because v1 metadata
files are allowed in v2 ta
Readers may be more strict for m
RussellSpitzer commented on code in PR #11067:
URL: https://github.com/apache/iceberg/pull/11067#discussion_r1801414926
##
format/spec.md:
##
@@ -158,27 +158,27 @@ Readers should be more permissive because v1 metadata
files are allowed in v2 ta
Readers may be more strict for
ajantha-bhat commented on code in PR #11067:
URL: https://github.com/apache/iceberg/pull/11067#discussion_r1800898330
##
format/spec.md:
##
@@ -158,27 +158,27 @@ Readers should be more permissive because v1 metadata
files are allowed in v2 ta
Readers may be more strict for m
danielcweeks commented on code in PR #11067:
URL: https://github.com/apache/iceberg/pull/11067#discussion_r1800321978
##
format/spec.md:
##
@@ -158,27 +158,27 @@ Readers should be more permissive because v1 metadata
files are allowed in v2 ta
Readers may be more strict for m
ajantha-bhat commented on PR #11067:
URL: https://github.com/apache/iceberg/pull/11067#issuecomment-2412652792
New TOC with this change
https://github.com/user-attachments/assets/e469de32-a608-4277-8dda-63c40b0fe0e9";>
--
This is an automated message from the Apache Git Service.
ajantha-bhat commented on code in PR #11067:
URL: https://github.com/apache/iceberg/pull/11067#discussion_r1800310393
##
format/spec.md:
##
@@ -121,9 +121,9 @@ Tables do not require random-access writes. Once written,
data and metadata file
Tables do not require rename, except
rdblue commented on code in PR #11067:
URL: https://github.com/apache/iceberg/pull/11067#discussion_r1800199969
##
format/spec.md:
##
@@ -158,27 +158,27 @@ Readers should be more permissive because v1 metadata
files are allowed in v2 ta
Readers may be more strict for metadat
rdblue commented on code in PR #11067:
URL: https://github.com/apache/iceberg/pull/11067#discussion_r1800199082
##
format/spec.md:
##
@@ -121,9 +121,9 @@ Tables do not require random-access writes. Once written,
data and metadata file
Tables do not require rename, except for t
ajantha-bhat commented on PR #11067:
URL: https://github.com/apache/iceberg/pull/11067#issuecomment-2378429916
ping @rdblue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
RussellSpitzer commented on PR #11067:
URL: https://github.com/apache/iceberg/pull/11067#issuecomment-2362184526
I think this is probably a reasonable thing to do. Looking online,
apparently switching to a single H1 element will also help out screen readers
and accessibility software as wel
ajantha-bhat commented on PR #11067:
URL: https://github.com/apache/iceberg/pull/11067#issuecomment-2324762847
@RussellSpitzer: I have updated it today. Sorry for delay on this. I lost
track of this PR notification.
--
This is an automated message from the Apache Git Service.
To respond
ajantha-bhat opened a new pull request, #11067:
URL: https://github.com/apache/iceberg/pull/11067
Table of contents in the [spec web page](https://iceberg.apache.org/spec/)
is not generated for `spec` and its subsection after
https://github.com/apache/iceberg/pull/10948. It is super hard to
20 matches
Mail list logo
