HonahX merged PR #11660:
URL: https://github.com/apache/iceberg/pull/11660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
HonahX commented on PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#issuecomment-2613344942
Thanks @kevinjqliu @RussellSpitzer @sfc-gh-aixu @danielcweeks @rdblue for
reviewing!
The vote has passed:
https://lists.apache.org/thread/mz01jwt69osqxhx9d3dd9xzncv9yncd0
I
manuzhang commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1926261998
##
format/spec.md:
##
@@ -1633,3 +1633,47 @@ might indicate different snapshot IDs for a specific
timestamp. The discrepancie
When processing point in time quer
HonahX commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1924290468
##
format/spec.md:
##
@@ -1633,3 +1633,47 @@ might indicate different snapshot IDs for a specific
timestamp. The discrepancie
When processing point in time queries
HonahX commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1924290468
##
format/spec.md:
##
@@ -1633,3 +1633,47 @@ might indicate different snapshot IDs for a specific
timestamp. The discrepancie
When processing point in time queries
HonahX commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1924290468
##
format/spec.md:
##
@@ -1633,3 +1633,47 @@ might indicate different snapshot IDs for a specific
timestamp. The discrepancie
When processing point in time queries
HonahX commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1924290468
##
format/spec.md:
##
@@ -1633,3 +1633,47 @@ might indicate different snapshot IDs for a specific
timestamp. The discrepancie
When processing point in time queries
manuzhang commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1922366634
##
format/spec.md:
##
@@ -1633,3 +1633,47 @@ might indicate different snapshot IDs for a specific
timestamp. The discrepancie
When processing point in time quer
HonahX commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1919368343
##
format/spec.md:
##
@@ -1633,3 +1633,52 @@ might indicate different snapshot IDs for a specific
timestamp. The discrepancie
When processing point in time queries
HonahX commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1919368343
##
format/spec.md:
##
@@ -1633,3 +1633,52 @@ might indicate different snapshot IDs for a specific
timestamp. The discrepancie
When processing point in time queries
RussellSpitzer commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1919171364
##
format/spec.md:
##
@@ -1633,3 +1633,52 @@ might indicate different snapshot IDs for a specific
timestamp. The discrepancie
When processing point in time
RussellSpitzer commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1919172817
##
format/spec.md:
##
@@ -1633,3 +1633,50 @@ might indicate different snapshot IDs for a specific
timestamp. The discrepancie
When processing point in time
RussellSpitzer commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1919170216
##
format/spec.md:
##
@@ -1633,3 +1633,52 @@ might indicate different snapshot IDs for a specific
timestamp. The discrepancie
When processing point in time
HonahX commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1919050911
##
format/spec.md:
##
@@ -1633,3 +1633,50 @@ might indicate different snapshot IDs for a specific
timestamp. The discrepancie
When processing point in time queries
kevinjqliu commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1918963008
##
format/spec.md:
##
@@ -1633,3 +1633,50 @@ might indicate different snapshot IDs for a specific
timestamp. The discrepancie
When processing point in time que
HonahX commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1917478351
##
format/spec.md:
##
@@ -1633,3 +1633,50 @@ might indicate different snapshot IDs for a specific
timestamp. The discrepancie
When processing point in time queries
HonahX commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1917473314
##
format/spec.md:
##
@@ -1633,3 +1633,50 @@ might indicate different snapshot IDs for a specific
timestamp. The discrepancie
When processing point in time queries
danielcweeks commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1917178042
##
format/spec.md:
##
@@ -1633,3 +1633,50 @@ might indicate different snapshot IDs for a specific
timestamp. The discrepancie
When processing point in time q
manuzhang commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1915810877
##
format/spec.md:
##
@@ -1633,3 +1633,50 @@ might indicate different snapshot IDs for a specific
timestamp. The discrepancie
When processing point in time quer
rdblue commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1915780926
##
format/spec.md:
##
@@ -1633,3 +1633,50 @@ might indicate different snapshot IDs for a specific
timestamp. The discrepancie
When processing point in time queries
RussellSpitzer commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1915505397
##
format/spec.md:
##
@@ -1633,3 +1633,57 @@ might indicate different snapshot IDs for a specific
timestamp. The discrepancie
When processing point in time
RussellSpitzer commented on PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#issuecomment-2590959103
@HonahX I think we are good on this one, I don't think we had any negative
feedback from the dev list. So I think we are good to merge if you are ready.
--
This is an automated
HonahX commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1910897271
##
format/spec.md:
##
@@ -1633,3 +1633,57 @@ might indicate different snapshot IDs for a specific
timestamp. The discrepancie
When processing point in time queries
kevinjqliu commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1905905118
##
format/spec.md:
##
@@ -1633,3 +1633,57 @@ might indicate different snapshot IDs for a specific
timestamp. The discrepancie
When processing point in time que
HonahX commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1902124366
##
format/spec.md:
##
@@ -1633,3 +1633,57 @@ might indicate different snapshot IDs for a specific
timestamp. The discrepancie
When processing point in time queries
HonahX commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1902124366
##
format/spec.md:
##
@@ -1633,3 +1633,57 @@ might indicate different snapshot IDs for a specific
timestamp. The discrepancie
When processing point in time queries
HonahX commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1902114140
##
format/spec.md:
##
@@ -1633,3 +1633,57 @@ might indicate different snapshot IDs for a specific
timestamp. The discrepancie
When processing point in time queries
RussellSpitzer commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1901893758
##
format/spec.md:
##
@@ -1633,3 +1633,57 @@ might indicate different snapshot IDs for a specific
timestamp. The discrepancie
When processing point in time
RussellSpitzer commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1901891884
##
format/spec.md:
##
@@ -1633,3 +1633,57 @@ might indicate different snapshot IDs for a specific
timestamp. The discrepancie
When processing point in time
HonahX commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1901143637
##
format/spec.md:
##
@@ -693,6 +686,64 @@ A snapshot's `first-row-id` is assigned to the table's
current `next-row-id` on
The snapshot's `first-row-id` is the start
HonahX commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1894512326
##
format/spec.md:
##
@@ -693,6 +686,64 @@ A snapshot's `first-row-id` is assigned to the table's
current `next-row-id` on
The snapshot's `first-row-id` is the start
HonahX commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1894512326
##
format/spec.md:
##
@@ -693,6 +686,64 @@ A snapshot's `first-row-id` is assigned to the table's
current `next-row-id` on
The snapshot's `first-row-id` is the start
HonahX commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1901398996
##
format/spec.md:
##
@@ -693,6 +686,64 @@ A snapshot's `first-row-id` is assigned to the table's
current `next-row-id` on
The snapshot's `first-row-id` is the start
RussellSpitzer commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1881106923
##
format/spec.md:
##
@@ -693,6 +686,64 @@ A snapshot's `first-row-id` is assigned to the table's
current `next-row-id` on
The snapshot's `first-row-id` is t
RussellSpitzer commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1881106567
##
format/spec.md:
##
@@ -693,6 +686,64 @@ A snapshot's `first-row-id` is assigned to the table's
current `next-row-id` on
The snapshot's `first-row-id` is t
RussellSpitzer commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1881105847
##
format/spec.md:
##
@@ -693,6 +686,64 @@ A snapshot's `first-row-id` is assigned to the table's
current `next-row-id` on
The snapshot's `first-row-id` is t
RussellSpitzer commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1881104193
##
format/spec.md:
##
@@ -693,6 +686,64 @@ A snapshot's `first-row-id` is assigned to the table's
current `next-row-id` on
The snapshot's `first-row-id` is t
RussellSpitzer commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1881103731
##
format/spec.md:
##
@@ -693,6 +686,64 @@ A snapshot's `first-row-id` is assigned to the table's
current `next-row-id` on
The snapshot's `first-row-id` is t
RussellSpitzer commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1881105376
##
format/spec.md:
##
@@ -693,6 +686,64 @@ A snapshot's `first-row-id` is assigned to the table's
current `next-row-id` on
The snapshot's `first-row-id` is t
RussellSpitzer commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1881105008
##
format/spec.md:
##
@@ -693,6 +686,64 @@ A snapshot's `first-row-id` is assigned to the table's
current `next-row-id` on
The snapshot's `first-row-id` is t
RussellSpitzer commented on code in PR #11660:
URL: https://github.com/apache/iceberg/pull/11660#discussion_r1881103356
##
format/spec.md:
##
@@ -693,6 +686,64 @@ A snapshot's `first-row-id` is assigned to the table's
current `next-row-id` on
The snapshot's `first-row-id` is t
HonahX opened a new pull request, #11660:
URL: https://github.com/apache/iceberg/pull/11660
This PR introduces a new section, "Snapshot Summary", in the table spec
under [Snapshots](https://iceberg.apache.org/spec/#snapshots) to document
optional fields in the snapshot summary, including me
42 matches
Mail list logo