Re: [PR] Spec: Clarify which columns can be used for equality delete files. [iceberg]

2024-07-19 Thread via GitHub
jackye1995 merged PR #8981: URL: https://github.com/apache/iceberg/pull/8981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] Spec: Clarify which columns can be used for equality delete files. [iceberg]

2024-07-19 Thread via GitHub
jackye1995 commented on PR #8981: URL: https://github.com/apache/iceberg/pull/8981#issuecomment-2239715035 Merging as the vote has passed: https://lists.apache.org/thread/9o42rkytm2l86kojmdl9xn3g9n9nhfvh -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] Spec: Clarify which columns can be used for equality delete files. [iceberg]

2024-07-11 Thread via GitHub
Fokko commented on code in PR #8981: URL: https://github.com/apache/iceberg/pull/8981#discussion_r1673839996 ## format/spec.md: ## @@ -842,7 +842,8 @@ The rows in the delete file must be sorted by `file_path` then `pos` to optimize Equality delete files identify deleted rows

Re: [PR] Spec: Clarify which columns can be used for equality delete files. [iceberg]

2024-04-15 Thread via GitHub
emkornfield commented on PR #8981: URL: https://github.com/apache/iceberg/pull/8981#issuecomment-2057612264 @Fokko just wanted to see if you have bandwidth to take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Spec: Clarify which columns can be used for equality delete files. [iceberg]

2024-02-19 Thread via GitHub
emkornfield commented on code in PR #8981: URL: https://github.com/apache/iceberg/pull/8981#discussion_r1494946656 ## format/spec.md: ## @@ -842,7 +842,8 @@ The rows in the delete file must be sorted by `file_path` then `pos` to optimize Equality delete files identify delete

Re: [PR] Spec: Clarify which columns can be used for equality delete files. [iceberg]

2024-01-27 Thread via GitHub
emkornfield commented on PR #8981: URL: https://github.com/apache/iceberg/pull/8981#issuecomment-1913366693 @Fokko @rdblue would you mind reviewing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Spec: Clarify which columns can be used for equality delete files. [iceberg]

2024-01-08 Thread via GitHub
Fokko commented on code in PR #8981: URL: https://github.com/apache/iceberg/pull/8981#discussion_r1444618855 ## format/spec.md: ## @@ -842,7 +842,8 @@ The rows in the delete file must be sorted by `file_path` then `pos` to optimize Equality delete files identify deleted rows

Re: [PR] Spec: Clarify which columns can be used for equality delete files. [iceberg]

2024-01-07 Thread via GitHub
emkornfield commented on PR #8981: URL: https://github.com/apache/iceberg/pull/8981#issuecomment-1880477089 @Fokko or @rdblue happy new year, would have bandwidth to review/merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] Spec: Clarify which columns can be used for equality delete files. [iceberg]

2023-12-08 Thread via GitHub
emkornfield commented on PR #8981: URL: https://github.com/apache/iceberg/pull/8981#issuecomment-1847573238 @Fokko or @rdblue would you mind taking a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Spec: Clarify which columns can be used for equality delete files. [iceberg]

2023-11-09 Thread via GitHub
gaborkaszab commented on code in PR #8981: URL: https://github.com/apache/iceberg/pull/8981#discussion_r1387779741 ## format/spec.md: ## @@ -842,7 +842,8 @@ The rows in the delete file must be sorted by `file_path` then `pos` to optimize Equality delete files identify delete

Re: [PR] Spec: Clarify which columns can be used for equality delete files. [iceberg]

2023-11-08 Thread via GitHub
emkornfield commented on code in PR #8981: URL: https://github.com/apache/iceberg/pull/8981#discussion_r1387018427 ## format/spec.md: ## @@ -842,7 +842,8 @@ The rows in the delete file must be sorted by `file_path` then `pos` to optimize Equality delete files identify delete

Re: [PR] Spec: Clarify which columns can be used for equality delete files. [iceberg]

2023-11-08 Thread via GitHub
liurenjie1024 commented on code in PR #8981: URL: https://github.com/apache/iceberg/pull/8981#discussion_r1386629666 ## format/spec.md: ## @@ -842,7 +842,8 @@ The rows in the delete file must be sorted by `file_path` then `pos` to optimize Equality delete files identify dele

Re: [PR] Spec: Clarify which columns can be used for equality delete files. [iceberg]

2023-11-08 Thread via GitHub
gaborkaszab commented on code in PR #8981: URL: https://github.com/apache/iceberg/pull/8981#discussion_r1386511343 ## format/spec.md: ## @@ -842,7 +842,8 @@ The rows in the delete file must be sorted by `file_path` then `pos` to optimize Equality delete files identify delete

Re: [PR] Spec: Clarify which columns can be used for equality delete files. [iceberg]

2023-11-08 Thread via GitHub
liurenjie1024 commented on code in PR #8981: URL: https://github.com/apache/iceberg/pull/8981#discussion_r138616 ## format/spec.md: ## @@ -842,7 +842,8 @@ The rows in the delete file must be sorted by `file_path` then `pos` to optimize Equality delete files identify dele

Re: [PR] Spec: Clarify which columns can be used for equality delete files. [iceberg]

2023-11-08 Thread via GitHub
gaborkaszab commented on code in PR #8981: URL: https://github.com/apache/iceberg/pull/8981#discussion_r1386184942 ## format/spec.md: ## @@ -842,7 +842,8 @@ The rows in the delete file must be sorted by `file_path` then `pos` to optimize Equality delete files identify delete

Re: [PR] Spec: Clarify which columns can be used for equality delete files. [iceberg]

2023-11-07 Thread via GitHub
liurenjie1024 commented on code in PR #8981: URL: https://github.com/apache/iceberg/pull/8981#discussion_r1384272688 ## format/spec.md: ## @@ -842,7 +842,8 @@ The rows in the delete file must be sorted by `file_path` then `pos` to optimize Equality delete files identify dele

Re: [PR] Spec: Clarify which columns can be used for equality delete files. [iceberg]

2023-11-07 Thread via GitHub
liurenjie1024 commented on code in PR #8981: URL: https://github.com/apache/iceberg/pull/8981#discussion_r1385849323 ## format/spec.md: ## @@ -842,7 +842,8 @@ The rows in the delete file must be sorted by `file_path` then `pos` to optimize Equality delete files identify dele