Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

rdblue commented on PR #8982: URL: https://github.com/apache/iceberg/pull/8982#issuecomment-2246312338 Looks like we have reached consensus, so I'll go ahead and merge this. Thanks for the addition, @emkornfield! -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

rdblue merged PR #8982: URL: https://github.com/apache/iceberg/pull/8982 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

dimas-b commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1688102735 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2 tabl

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

emkornfield commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1687393769 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

emkornfield commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1687392310 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

emkornfield commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1687392645 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

dimas-b commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1687279691 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2 tabl

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

rdblue commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1687239911 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2 table

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

dimas-b commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1687195172 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2 tabl

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

emkornfield commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1686992661 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

emkornfield commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1686982629 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

dimas-b commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1686695087 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2 tabl

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

ajantha-bhat commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1686001845 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

ajantha-bhat commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1685995645 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

ajantha-bhat commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1685990795 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

stevenzwu commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1685029473 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2 ta

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

RussellSpitzer commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1684924865 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

RussellSpitzer commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1684923930 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

emkornfield commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1684871640 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

emkornfield commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1684868554 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

rdblue commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1684803263 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2 table

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

rdblue commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1684799208 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2 table

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

snazy commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1684706987 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2 table.

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

ajantha-bhat commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1684688004 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

ajantha-bhat commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1684688004 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

jbonofre commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1684674382 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2 tab

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

jackye1995 commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1684579903 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2 t

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

emkornfield commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1683968054 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

emkornfield commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1683967723 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

rdblue commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1683583050 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2 table

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

RussellSpitzer commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1679493073 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

stevenzwu commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1678756567 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2 ta

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

stevenzwu commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1678739020 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2 ta

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

stevenzwu commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1678736424 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2 ta

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

Fokko commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1673855957 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2 table.

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

Fokko commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1673855957 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2 table.

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

Fokko commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1673841605 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2 table.

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

emkornfield commented on PR #8982: URL: https://github.com/apache/iceberg/pull/8982#issuecomment-2057613376 @Fokko @aokolnychyi just wanted to ping again to see if you have bandwidth to take another look? -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

emkornfield commented on PR #8982: URL: https://github.com/apache/iceberg/pull/8982#issuecomment-1913366641 @Fokko @aokolnychyi would you mind taking a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

emkornfield commented on PR #8982: URL: https://github.com/apache/iceberg/pull/8982#issuecomment-1880476786 @aokolnychyi happy new year! Would you mind taking a second look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

emkornfield commented on PR #8982: URL: https://github.com/apache/iceberg/pull/8982#issuecomment-1847572861 @aokolnychyi did my changes address your feedback properly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

emkornfield commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1385985134 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

aokolnychyi commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1385798919 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

aokolnychyi commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1385797897 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2