Re: [PR] Spec: Clarify spec_id field in Data File [iceberg]

2024-09-28 Thread via GitHub
github-actions[bot] closed pull request #8730: Spec: Clarify spec_id field in Data File URL: https://github.com/apache/iceberg/pull/8730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Spec: Clarify spec_id field in Data File [iceberg]

2024-09-28 Thread via GitHub
github-actions[bot] commented on PR #8730: URL: https://github.com/apache/iceberg/pull/8730#issuecomment-2381033267 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If y

Re: [PR] Spec: Clarify spec_id field in Data File [iceberg]

2024-09-21 Thread via GitHub
github-actions[bot] commented on PR #8730: URL: https://github.com/apache/iceberg/pull/8730#issuecomment-2365374241 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] Spec: Clarify spec_id field in Data File [iceberg]

2023-10-26 Thread via GitHub
rdblue commented on code in PR #8730: URL: https://github.com/apache/iceberg/pull/8730#discussion_r1373912012 ## format/spec.md: ## @@ -443,13 +443,13 @@ The schema of a manifest file is a struct called `manifest_entry` with the follo | _optional_ | _optional_ | **`132 split_

Re: [PR] Spec: Clarify spec_id field in Data File [iceberg]

2023-10-26 Thread via GitHub
rdblue commented on code in PR #8730: URL: https://github.com/apache/iceberg/pull/8730#discussion_r1373911335 ## format/spec.md: ## @@ -443,13 +443,13 @@ The schema of a manifest file is a struct called `manifest_entry` with the follo | _optional_ | _optional_ | **`132 split_

Re: [PR] Spec: Clarify spec_id field in Data File [iceberg]

2023-10-12 Thread via GitHub
Fokko commented on code in PR #8730: URL: https://github.com/apache/iceberg/pull/8730#discussion_r1357291336 ## format/spec.md: ## @@ -443,13 +443,13 @@ The schema of a manifest file is a struct called `manifest_entry` with the follo | _optional_ | _optional_ | **`132 split_o

Re: [PR] Spec: Clarify spec_id field in Data File [iceberg]

2023-10-09 Thread via GitHub
aokolnychyi commented on code in PR #8730: URL: https://github.com/apache/iceberg/pull/8730#discussion_r1350806829 ## format/spec.md: ## @@ -443,13 +443,13 @@ The schema of a manifest file is a struct called `manifest_entry` with the follo | _optional_ | _optional_ | **`132 s

Re: [PR] Spec: Clarify spec_id field in Data File [iceberg]

2023-10-08 Thread via GitHub
rdblue commented on code in PR #8730: URL: https://github.com/apache/iceberg/pull/8730#discussion_r1349759341 ## format/spec.md: ## @@ -443,13 +443,13 @@ The schema of a manifest file is a struct called `manifest_entry` with the follo | _optional_ | _optional_ | **`132 split_

Re: [PR] Spec: Clarify spec_id field in Data File [iceberg]

2023-10-08 Thread via GitHub
rdblue commented on code in PR #8730: URL: https://github.com/apache/iceberg/pull/8730#discussion_r1349759341 ## format/spec.md: ## @@ -443,13 +443,13 @@ The schema of a manifest file is a struct called `manifest_entry` with the follo | _optional_ | _optional_ | **`132 split_

Re: [PR] Spec: Clarify spec_id field in Data File [iceberg]

2023-10-07 Thread via GitHub
Fokko commented on code in PR #8730: URL: https://github.com/apache/iceberg/pull/8730#discussion_r1349555314 ## format/spec.md: ## @@ -443,13 +443,13 @@ The schema of a manifest file is a struct called `manifest_entry` with the follo | _optional_ | _optional_ | **`132 split_o

Re: [PR] Spec: Clarify spec_id field in Data File [iceberg]

2023-10-06 Thread via GitHub
amogh-jahagirdar commented on code in PR #8730: URL: https://github.com/apache/iceberg/pull/8730#discussion_r1348465225 ## format/spec.md: ## @@ -443,13 +443,13 @@ The schema of a manifest file is a struct called `manifest_entry` with the follo | _optional_ | _optional_ | **`1

Re: [PR] Spec: Clarify spec_id field in Data File [iceberg]

2023-10-06 Thread via GitHub
amogh-jahagirdar commented on code in PR #8730: URL: https://github.com/apache/iceberg/pull/8730#discussion_r1348465225 ## format/spec.md: ## @@ -443,13 +443,13 @@ The schema of a manifest file is a struct called `manifest_entry` with the follo | _optional_ | _optional_ | **`1

[PR] Spec: Clarify spec_id field in Data File [iceberg]

2023-10-06 Thread via GitHub
amogh-jahagirdar opened a new pull request, #8730: URL: https://github.com/apache/iceberg/pull/8730 Fixes #8712 . This clarifies the `spec_id` partition spec field in DataFile. Note that in practice this field looks to not be written and is simply inherited from the manifest file. We alread