Re: [PR] Spec: Clarify partition equality [iceberg]

2023-12-04 Thread via GitHub
rdblue merged PR #9125: URL: https://github.com/apache/iceberg/pull/9125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Spec: Clarify partition equality [iceberg]

2023-12-04 Thread via GitHub
rdblue commented on PR #9125: URL: https://github.com/apache/iceberg/pull/9125#issuecomment-1839350869 Thanks for the update, @emkornfield! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Spec: Clarify partition equality [iceberg]

2023-12-04 Thread via GitHub
rdblue commented on code in PR #9125: URL: https://github.com/apache/iceberg/pull/9125#discussion_r1414398386 ## format/spec.md: ## @@ -607,6 +611,8 @@ Notes: 1. An alternative, *strict projection*, creates a partition predicate that will match a file if all of the rows in t

Re: [PR] Spec: Clarify partition equality [iceberg]

2023-12-04 Thread via GitHub
rdblue commented on code in PR #9125: URL: https://github.com/apache/iceberg/pull/9125#discussion_r1414397271 ## format/spec.md: ## @@ -305,6 +305,10 @@ The source column, selected by id, must be a primitive type and cannot be contai Partition specs capture the transform fro

Re: [PR] Spec: Clarify partition equality [iceberg]

2023-11-30 Thread via GitHub
emkornfield commented on PR #9125: URL: https://github.com/apache/iceberg/pull/9125#issuecomment-1835537324 > Not for this PR, but the same principle also applies to schemas and sort-orders. @Fokko could you clarify what you mean by schemas? I thought for sorting the following

Re: [PR] Spec: Clarify partition equality [iceberg]

2023-11-30 Thread via GitHub
Fokko commented on code in PR #9125: URL: https://github.com/apache/iceberg/pull/9125#discussion_r1411626147 ## format/spec.md: ## @@ -607,6 +610,7 @@ Notes: 1. An alternative, *strict projection*, creates a partition predicate that will match a file if all of the rows in th

Re: [PR] Spec: Clarify partition equality [iceberg]

2023-11-26 Thread via GitHub
emkornfield commented on code in PR #9125: URL: https://github.com/apache/iceberg/pull/9125#discussion_r1405548802 ## format/spec.md: ## @@ -305,6 +305,13 @@ The source column, selected by id, must be a primitive type and cannot be contai Partition specs capture the transfor

Re: [PR] Spec: Clarify partition equality [iceberg]

2023-11-26 Thread via GitHub
emkornfield commented on code in PR #9125: URL: https://github.com/apache/iceberg/pull/9125#discussion_r1405548509 ## format/spec.md: ## @@ -305,6 +305,10 @@ The source column, selected by id, must be a primitive type and cannot be contai Partition specs capture the transfor

Re: [PR] Spec: Clarify partition equality [iceberg]

2023-11-26 Thread via GitHub
emkornfield commented on code in PR #9125: URL: https://github.com/apache/iceberg/pull/9125#discussion_r1405547938 ## format/spec.md: ## @@ -305,6 +305,13 @@ The source column, selected by id, must be a primitive type and cannot be contai Partition specs capture the transfor

Re: [PR] Spec: Clarify partition equality [iceberg]

2023-11-26 Thread via GitHub
emkornfield commented on code in PR #9125: URL: https://github.com/apache/iceberg/pull/9125#discussion_r1405545902 ## format/spec.md: ## @@ -607,6 +614,8 @@ Notes: 1. An alternative, *strict projection*, creates a partition predicate that will match a file if all of the rows

Re: [PR] Spec: Clarify partition equality [iceberg]

2023-11-26 Thread via GitHub
emkornfield commented on code in PR #9125: URL: https://github.com/apache/iceberg/pull/9125#discussion_r1405545902 ## format/spec.md: ## @@ -607,6 +614,8 @@ Notes: 1. An alternative, *strict projection*, creates a partition predicate that will match a file if all of the rows

Re: [PR] Spec: Clarify partition equality [iceberg]

2023-11-25 Thread via GitHub
rdblue commented on code in PR #9125: URL: https://github.com/apache/iceberg/pull/9125#discussion_r1405221338 ## format/spec.md: ## @@ -305,6 +305,13 @@ The source column, selected by id, must be a primitive type and cannot be contai Partition specs capture the transform fro

Re: [PR] Spec: Clarify partition equality [iceberg]

2023-11-25 Thread via GitHub
rdblue commented on code in PR #9125: URL: https://github.com/apache/iceberg/pull/9125#discussion_r1405221265 ## format/spec.md: ## @@ -607,6 +614,8 @@ Notes: 1. An alternative, *strict projection*, creates a partition predicate that will match a file if all of the rows in t

Re: [PR] Spec: Clarify partition equality [iceberg]

2023-11-25 Thread via GitHub
rdblue commented on code in PR #9125: URL: https://github.com/apache/iceberg/pull/9125#discussion_r1405221130 ## format/spec.md: ## @@ -607,6 +614,8 @@ Notes: 1. An alternative, *strict projection*, creates a partition predicate that will match a file if all of the rows in t

Re: [PR] Spec: Clarify partition equality [iceberg]

2023-11-24 Thread via GitHub
emkornfield commented on code in PR #9125: URL: https://github.com/apache/iceberg/pull/9125#discussion_r1404503860 ## format/spec.md: ## @@ -305,6 +305,10 @@ The source column, selected by id, must be a primitive type and cannot be contai Partition specs capture the transfor

Re: [PR] Spec: Clarify partition equality [iceberg]

2023-11-24 Thread via GitHub
emkornfield commented on code in PR #9125: URL: https://github.com/apache/iceberg/pull/9125#discussion_r1404501309 ## format/spec.md: ## @@ -607,6 +611,8 @@ Notes: 1. An alternative, *strict projection*, creates a partition predicate that will match a file if all of the rows

Re: [PR] Spec: Clarify partition equality [iceberg]

2023-11-24 Thread via GitHub
emkornfield commented on code in PR #9125: URL: https://github.com/apache/iceberg/pull/9125#discussion_r1404499619 ## format/spec.md: ## @@ -607,6 +611,8 @@ Notes: 1. An alternative, *strict projection*, creates a partition predicate that will match a file if all of the rows

Re: [PR] Spec: Clarify partition equality [iceberg]

2023-11-22 Thread via GitHub
rdblue commented on code in PR #9125: URL: https://github.com/apache/iceberg/pull/9125#discussion_r1402521562 ## format/spec.md: ## @@ -305,6 +305,10 @@ The source column, selected by id, must be a primitive type and cannot be contai Partition specs capture the transform fro

Re: [PR] Spec: Clarify partition equality [iceberg]

2023-11-22 Thread via GitHub
rdblue commented on code in PR #9125: URL: https://github.com/apache/iceberg/pull/9125#discussion_r1402519684 ## format/spec.md: ## @@ -607,6 +611,8 @@ Notes: 1. An alternative, *strict projection*, creates a partition predicate that will match a file if all of the rows in t

Re: [PR] Spec: Clarify partition equality [iceberg]

2023-11-22 Thread via GitHub
rdblue commented on code in PR #9125: URL: https://github.com/apache/iceberg/pull/9125#discussion_r1402518409 ## format/spec.md: ## @@ -607,6 +611,8 @@ Notes: 1. An alternative, *strict projection*, creates a partition predicate that will match a file if all of the rows in t

Re: [PR] Spec: Clarify partition equality [iceberg]

2023-11-22 Thread via GitHub
gaborkaszab commented on code in PR #9125: URL: https://github.com/apache/iceberg/pull/9125#discussion_r1401651708 ## format/spec.md: ## @@ -305,6 +305,10 @@ The source column, selected by id, must be a primitive type and cannot be contai Partition specs capture the transfor

[PR] Spec: Clarify partition equality [iceberg]

2023-11-21 Thread via GitHub
emkornfield opened a new pull request, #9125: URL: https://github.com/apache/iceberg/pull/9125 Based on conversation on mailing list: https://lists.apache.org/thread/z5y4qgf1hpc5y5krptb71lx0q1yx9gtx I made an assumption on how floating point partitions should be considered for equali