Re: [PR] Spec: Clarify missing fields when writing [iceberg]

2024-04-25 Thread via GitHub
Fokko commented on PR #8672: URL: https://github.com/apache/iceberg/pull/8672#issuecomment-2078739565 I'll go ahead and merge this now. EVery now and then a question around this pops up on the devlist/Slack, so it is good to get this clarification out. Thanks everyone for chiming in for the

Re: [PR] Spec: Clarify missing fields when writing [iceberg]

2024-04-25 Thread via GitHub
Fokko merged PR #8672: URL: https://github.com/apache/iceberg/pull/8672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

Re: [PR] Spec: Clarify missing fields when writing [iceberg]

2024-04-23 Thread via GitHub
Fokko commented on code in PR #8672: URL: https://github.com/apache/iceberg/pull/8672#discussion_r1575985773 ## format/spec.md: ## @@ -128,12 +128,12 @@ Tables do not require rename, except for tables that use atomic rename to implem Writer requirements -Some tables i

Re: [PR] Spec: Clarify missing fields when writing [iceberg]

2024-04-23 Thread via GitHub
Fokko commented on code in PR #8672: URL: https://github.com/apache/iceberg/pull/8672#discussion_r1575985072 ## format/spec.md: ## @@ -128,12 +128,12 @@ Tables do not require rename, except for tables that use atomic rename to implem Writer requirements -Some tables i

Re: [PR] Spec: Clarify missing fields when writing [iceberg]

2024-04-22 Thread via GitHub
stevenzwu commented on code in PR #8672: URL: https://github.com/apache/iceberg/pull/8672#discussion_r1575469747 ## format/spec.md: ## @@ -128,12 +128,12 @@ Tables do not require rename, except for tables that use atomic rename to implem Writer requirements -Some tabl

Re: [PR] Spec: Clarify missing fields when writing [iceberg]

2024-04-22 Thread via GitHub
jzhuge commented on PR #8672: URL: https://github.com/apache/iceberg/pull/8672#issuecomment-2071094487 +1 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] Spec: Clarify missing fields when writing [iceberg]

2023-10-27 Thread via GitHub
Fokko commented on code in PR #8672: URL: https://github.com/apache/iceberg/pull/8672#discussion_r1375043993 ## format/spec.md: ## @@ -128,13 +128,13 @@ Tables do not require rename, except for tables that use atomic rename to implem Writer requirements -Some tables i

Re: [PR] Spec: Clarify missing fields when writing [iceberg]

2023-10-08 Thread via GitHub
ajantha-bhat commented on code in PR #8672: URL: https://github.com/apache/iceberg/pull/8672#discussion_r1349879908 ## format/spec.md: ## @@ -128,13 +128,13 @@ Tables do not require rename, except for tables that use atomic rename to implem Writer requirements -Some t

Re: [PR] Spec: Clarify missing fields when writing [iceberg]

2023-10-08 Thread via GitHub
Fokko commented on code in PR #8672: URL: https://github.com/apache/iceberg/pull/8672#discussion_r1349779513 ## format/spec.md: ## @@ -128,13 +128,13 @@ Tables do not require rename, except for tables that use atomic rename to implem Writer requirements -Some tables i

Re: [PR] Spec: Clarify missing fields when writing [iceberg]

2023-10-08 Thread via GitHub
Fokko commented on code in PR #8672: URL: https://github.com/apache/iceberg/pull/8672#discussion_r1349779366 ## format/spec.md: ## @@ -128,13 +128,13 @@ Tables do not require rename, except for tables that use atomic rename to implem Writer requirements -Some tables i

Re: [PR] Spec: Clarify missing fields when writing [iceberg]

2023-10-08 Thread via GitHub
Fokko commented on code in PR #8672: URL: https://github.com/apache/iceberg/pull/8672#discussion_r1349779338 ## format/spec.md: ## @@ -128,13 +128,13 @@ Tables do not require rename, except for tables that use atomic rename to implem Writer requirements -Some tables i

Re: [PR] Spec: Clarify missing fields when writing [iceberg]

2023-10-05 Thread via GitHub
rdblue commented on code in PR #8672: URL: https://github.com/apache/iceberg/pull/8672#discussion_r1347854144 ## format/spec.md: ## @@ -128,13 +128,13 @@ Tables do not require rename, except for tables that use atomic rename to implem Writer requirements -Some tables

Re: [PR] Spec: Clarify missing fields when writing [iceberg]

2023-10-05 Thread via GitHub
rdblue commented on code in PR #8672: URL: https://github.com/apache/iceberg/pull/8672#discussion_r1347851474 ## format/spec.md: ## @@ -128,13 +128,13 @@ Tables do not require rename, except for tables that use atomic rename to implem Writer requirements -Some tables

Re: [PR] Spec: Clarify missing fields when writing [iceberg]

2023-10-05 Thread via GitHub
rdblue commented on code in PR #8672: URL: https://github.com/apache/iceberg/pull/8672#discussion_r1347851058 ## format/spec.md: ## @@ -128,13 +128,13 @@ Tables do not require rename, except for tables that use atomic rename to implem Writer requirements -Some tables