Re: [PR] Spark 3.5: Support specifying filter in RewriteManifestsProcedure [iceberg]

2024-10-19 Thread via GitHub
github-actions[bot] closed pull request #9447: Spark 3.5: Support specifying filter in RewriteManifestsProcedure URL: https://github.com/apache/iceberg/pull/9447 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] Spark 3.5: Support specifying filter in RewriteManifestsProcedure [iceberg]

2024-10-19 Thread via GitHub
github-actions[bot] commented on PR #9447: URL: https://github.com/apache/iceberg/pull/9447#issuecomment-2424318521 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If y

Re: [PR] Spark 3.5: Support specifying filter in RewriteManifestsProcedure [iceberg]

2024-10-12 Thread via GitHub
github-actions[bot] commented on PR #9447: URL: https://github.com/apache/iceberg/pull/9447#issuecomment-2408754895 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] Spark 3.5: Support specifying filter in RewriteManifestsProcedure [iceberg]

2024-05-06 Thread via GitHub
chenwyi2 commented on code in PR #9447: URL: https://github.com/apache/iceberg/pull/9447#discussion_r1590740653 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteManifestsProcedure.java: ## @@ -118,4 +126,15 @@ private InternalRow[] toOutputRows(Rewrit

Re: [PR] Spark 3.5: Support specifying filter in RewriteManifestsProcedure [iceberg]

2024-02-01 Thread via GitHub
zinking commented on code in PR #9447: URL: https://github.com/apache/iceberg/pull/9447#discussion_r1474296939 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteManifestsProcedure.java: ## @@ -118,4 +126,15 @@ private InternalRow[] toOutputRows(Rewrite

Re: [PR] Spark 3.5: Support specifying filter in RewriteManifestsProcedure [iceberg]

2024-02-01 Thread via GitHub
zinking commented on code in PR #9447: URL: https://github.com/apache/iceberg/pull/9447#discussion_r1474296939 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteManifestsProcedure.java: ## @@ -118,4 +126,15 @@ private InternalRow[] toOutputRows(Rewrite

Re: [PR] Spark 3.5: Support specifying filter in RewriteManifestsProcedure [iceberg]

2024-01-29 Thread via GitHub
bknbkn commented on code in PR #9447: URL: https://github.com/apache/iceberg/pull/9447#discussion_r1470704554 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteManifestsProcedure.java: ## @@ -118,4 +126,15 @@ private InternalRow[] toOutputRows(RewriteM

Re: [PR] Spark 3.5: Support specifying filter in RewriteManifestsProcedure [iceberg]

2024-01-26 Thread via GitHub
aokolnychyi commented on code in PR #9447: URL: https://github.com/apache/iceberg/pull/9447#discussion_r1468199919 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteManifestsProcedure.java: ## @@ -118,4 +126,15 @@ private InternalRow[] toOutputRows(Rew

Re: [PR] Spark 3.5: Support specifying filter in RewriteManifestsProcedure [iceberg]

2024-01-19 Thread via GitHub
bknbkn commented on code in PR #9447: URL: https://github.com/apache/iceberg/pull/9447#discussion_r1458505983 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteManifestsProcedure.java: ## @@ -118,4 +126,15 @@ private InternalRow[] toOutputRows(RewriteM

Re: [PR] Spark 3.5: Support specifying filter in RewriteManifestsProcedure [iceberg]

2024-01-19 Thread via GitHub
bknbkn commented on code in PR #9447: URL: https://github.com/apache/iceberg/pull/9447#discussion_r1458505983 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteManifestsProcedure.java: ## @@ -118,4 +126,15 @@ private InternalRow[] toOutputRows(RewriteM

Re: [PR] Spark 3.5: Support specifying filter in RewriteManifestsProcedure [iceberg]

2024-01-19 Thread via GitHub
bknbkn commented on code in PR #9447: URL: https://github.com/apache/iceberg/pull/9447#discussion_r1458505983 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteManifestsProcedure.java: ## @@ -118,4 +126,15 @@ private InternalRow[] toOutputRows(RewriteM

Re: [PR] Spark 3.5: Support specifying filter in RewriteManifestsProcedure [iceberg]

2024-01-18 Thread via GitHub
bknbkn commented on code in PR #9447: URL: https://github.com/apache/iceberg/pull/9447#discussion_r1458505983 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteManifestsProcedure.java: ## @@ -118,4 +126,15 @@ private InternalRow[] toOutputRows(RewriteM

Re: [PR] Spark 3.5: Support specifying filter in RewriteManifestsProcedure [iceberg]

2024-01-18 Thread via GitHub
bknbkn commented on code in PR #9447: URL: https://github.com/apache/iceberg/pull/9447#discussion_r1458505983 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteManifestsProcedure.java: ## @@ -118,4 +126,15 @@ private InternalRow[] toOutputRows(RewriteM

Re: [PR] Spark 3.5: Support specifying filter in RewriteManifestsProcedure [iceberg]

2024-01-18 Thread via GitHub
bknbkn commented on code in PR #9447: URL: https://github.com/apache/iceberg/pull/9447#discussion_r1458505983 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteManifestsProcedure.java: ## @@ -118,4 +126,15 @@ private InternalRow[] toOutputRows(RewriteM

Re: [PR] Spark 3.5: Support specifying filter in RewriteManifestsProcedure [iceberg]

2024-01-18 Thread via GitHub
aokolnychyi commented on code in PR #9447: URL: https://github.com/apache/iceberg/pull/9447#discussion_r1457935454 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteManifestsProcedure.java: ## @@ -118,4 +126,15 @@ private InternalRow[] toOutputRows(Rew

Re: [PR] Spark 3.5: Support specifying filter in RewriteManifestsProcedure [iceberg]

2024-01-16 Thread via GitHub
aokolnychyi commented on PR #9447: URL: https://github.com/apache/iceberg/pull/9447#issuecomment-1894364112 Will review this week, thanks for pinging, @bknbkn! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] Spark 3.5: Support specifying filter in RewriteManifestsProcedure [iceberg]

2024-01-09 Thread via GitHub
bknbkn commented on PR #9447: URL: https://github.com/apache/iceberg/pull/9447#issuecomment-1884154630 cc @aokolnychyi, would you mind to review this since you completed most parts of the rewrite manifests actions. Thanks a lot. -- This is an automated message from the Apache Git Service.

[PR] Spark 3.5: Support specifying filter in RewriteManifestsProcedure [iceberg]

2024-01-08 Thread via GitHub
bknbkn opened a new pull request, #9447: URL: https://github.com/apache/iceberg/pull/9447 This patch add `where` args in `RewritingManifestsProcedure`, It allows us to only rewrite the manifest file of the specified conditions. When we optimize the manifests of a large table, rewriting the