Re: [PR] Spark 3.5: Rework DeleteFileIndexBenchmark [iceberg]

2023-12-08 Thread via GitHub
aokolnychyi commented on PR #9165: URL: https://github.com/apache/iceberg/pull/9165#issuecomment-1846842066 Thanks for reviewing, @flyrain! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Spark 3.5: Rework DeleteFileIndexBenchmark [iceberg]

2023-12-08 Thread via GitHub
aokolnychyi merged PR #9165: URL: https://github.com/apache/iceberg/pull/9165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Spark 3.5: Rework DeleteFileIndexBenchmark [iceberg]

2023-12-08 Thread via GitHub
aokolnychyi commented on code in PR #9165: URL: https://github.com/apache/iceberg/pull/9165#discussion_r1420161870 ## core/src/test/java/org/apache/iceberg/FileGenerationUtil.java: ## @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

Re: [PR] Spark 3.5: Rework DeleteFileIndexBenchmark [iceberg]

2023-12-08 Thread via GitHub
aokolnychyi commented on code in PR #9165: URL: https://github.com/apache/iceberg/pull/9165#discussion_r1420161446 ## core/src/test/java/org/apache/iceberg/FileGenerationUtil.java: ## @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

Re: [PR] Spark 3.5: Rework DeleteFileIndexBenchmark [iceberg]

2023-12-07 Thread via GitHub
flyrain commented on code in PR #9165: URL: https://github.com/apache/iceberg/pull/9165#discussion_r1419397281 ## core/src/test/java/org/apache/iceberg/FileGenerationUtil.java: ## @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more co

[PR] Spark 3.5: Rework DeleteFileIndexBenchmark [iceberg]

2023-11-27 Thread via GitHub
aokolnychyi opened a new pull request, #9165: URL: https://github.com/apache/iceberg/pull/9165 This PR refactors `DeleteFileIndexBenchmark`: - Add `FileGenerationUtil` to be used in metadata benchmarks. - Use `FileGenerationUtil` to generate files to speed up the initialization pha