Re: [PR] Spark 3.5: Remove obsolete conf parsing logic [iceberg]

2024-05-11 Thread via GitHub
aokolnychyi commented on PR #10309: URL: https://github.com/apache/iceberg/pull/10309#issuecomment-2105954175 Thanks, @nastra! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] Spark 3.5: Remove obsolete conf parsing logic [iceberg]

2024-05-11 Thread via GitHub
aokolnychyi merged PR #10309: URL: https://github.com/apache/iceberg/pull/10309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@icebe

Re: [PR] Spark 3.5: Remove obsolete conf parsing logic [iceberg]

2024-05-10 Thread via GitHub
aokolnychyi commented on code in PR #10309: URL: https://github.com/apache/iceberg/pull/10309#discussion_r1597026741 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkConfParser.java: ## @@ -220,14 +228,10 @@ public ThisT tableProperty(String name) { }

Re: [PR] Spark 3.5: Remove obsolete conf parsing logic [iceberg]

2024-05-10 Thread via GitHub
aokolnychyi commented on code in PR #10309: URL: https://github.com/apache/iceberg/pull/10309#discussion_r1597026246 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkConfParser.java: ## @@ -220,14 +228,10 @@ public ThisT tableProperty(String name) { }

Re: [PR] Spark 3.5: Remove obsolete conf parsing logic [iceberg]

2024-05-10 Thread via GitHub
aokolnychyi commented on code in PR #10309: URL: https://github.com/apache/iceberg/pull/10309#discussion_r1597024872 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkConfParser.java: ## @@ -70,6 +70,14 @@ public DurationConfParser durationConf() { return new

[PR] Spark 3.5: Remove obsolete conf parsing logic [iceberg]

2024-05-10 Thread via GitHub
aokolnychyi opened a new pull request, #10309: URL: https://github.com/apache/iceberg/pull/10309 This PR removes some conf parsing logic that predates the split of Spark 2 and Spark 3. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to