github-actions[bot] closed pull request #10315: Spark 3.5: Add validation to
SparkConfParser
URL: https://github.com/apache/iceberg/pull/10315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
github-actions[bot] commented on PR #10315:
URL: https://github.com/apache/iceberg/pull/10315#issuecomment-2465928574
This pull request has been closed due to lack of activity. This is not a
judgement on the merit of the PR in any way. It is just a way of keeping the PR
queue manageable. If
github-actions[bot] commented on PR #10315:
URL: https://github.com/apache/iceberg/pull/10315#issuecomment-2452745576
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pul
jerqi commented on code in PR #10315:
URL: https://github.com/apache/iceberg/pull/10315#discussion_r1609368411
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkConfParser.java:
##
@@ -264,7 +261,26 @@ public ThisT tableProperty(String name) {
return self();
jerqi commented on code in PR #10315:
URL: https://github.com/apache/iceberg/pull/10315#discussion_r1609365261
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkConfParser.java:
##
@@ -233,19 +229,20 @@ public EnumConfParser defaultValue(String value) {
}
jerqi commented on code in PR #10315:
URL: https://github.com/apache/iceberg/pull/10315#discussion_r1609365261
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkConfParser.java:
##
@@ -233,19 +229,20 @@ public EnumConfParser defaultValue(String value) {
}
szehon-ho commented on code in PR #10315:
URL: https://github.com/apache/iceberg/pull/10315#discussion_r1605423430
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkConfParser.java:
##
@@ -264,7 +261,26 @@ public ThisT tableProperty(String name) {
return sel
szehon-ho commented on code in PR #10315:
URL: https://github.com/apache/iceberg/pull/10315#discussion_r1605423430
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkConfParser.java:
##
@@ -264,7 +261,26 @@ public ThisT tableProperty(String name) {
return sel
aokolnychyi commented on code in PR #10315:
URL: https://github.com/apache/iceberg/pull/10315#discussion_r1605416423
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkConfParser.java:
##
@@ -264,7 +261,26 @@ public ThisT tableProperty(String name) {
return s
szehon-ho commented on code in PR #10315:
URL: https://github.com/apache/iceberg/pull/10315#discussion_r1605401469
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkConfParser.java:
##
@@ -264,7 +261,26 @@ public ThisT tableProperty(String name) {
return sel
aokolnychyi commented on code in PR #10315:
URL: https://github.com/apache/iceberg/pull/10315#discussion_r1598999270
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkConfParser.java:
##
@@ -227,7 +225,26 @@ public ThisT tableProperty(String name) {
return s
manuzhang commented on code in PR #10315:
URL: https://github.com/apache/iceberg/pull/10315#discussion_r1598686177
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkConfParser.java:
##
@@ -227,7 +225,26 @@ public ThisT tableProperty(String name) {
return sel
aokolnychyi opened a new pull request, #10315:
URL: https://github.com/apache/iceberg/pull/10315
This PR adds a way to validate parsed configs in `SparkConfParser`. It is
intended for the following use:
```
public int parquetBatchSize() {
return confParser
.intConf()
13 matches
Mail list logo
