Re: [PR] Spark: remove ROW_POSITION from project schema [iceberg]

2024-11-28 Thread via GitHub
huaxingao commented on PR #11610: URL: https://github.com/apache/iceberg/pull/11610#issuecomment-2506923142 Thanks @flyrain -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Spark: remove ROW_POSITION from project schema [iceberg]

2024-11-28 Thread via GitHub
flyrain commented on PR #11610: URL: https://github.com/apache/iceberg/pull/11610#issuecomment-2506685944 Thanks for the change, @huaxingao ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Spark: remove ROW_POSITION from project schema [iceberg]

2024-11-28 Thread via GitHub
flyrain merged PR #11610: URL: https://github.com/apache/iceberg/pull/11610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.a

Re: [PR] Spark: remove ROW_POSITION from project schema [iceberg]

2024-11-21 Thread via GitHub
huaxingao commented on PR #11610: URL: https://github.com/apache/iceberg/pull/11610#issuecomment-2491897033 @flyrain Yes, we need the same change in the older version too. Just added the changes. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] Spark: remove ROW_POSITION from project schema [iceberg]

2024-11-21 Thread via GitHub
huaxingao commented on PR #11610: URL: https://github.com/apache/iceberg/pull/11610#issuecomment-2491748840 cc @flyrain @szehon-ho -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[PR] Spark: remove ROW_POSITION from project schema [iceberg]

2024-11-20 Thread via GitHub
huaxingao opened a new pull request, #11610: URL: https://github.com/apache/iceberg/pull/11610 Originally, we have `ReadConfig#generateOffsetToStartPos(Schema schema)` to compute the row offsets of the row groups. This method needs to check if the schema contains ROW_POSITION. https://githu