Re: [PR] Spark: Write DVs for V3 MoR tables [iceberg]

amogh-jahagirdar commented on code in PR #11561: URL: https://github.com/apache/iceberg/pull/11561#discussion_r1873686457 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkBatchQueryScan.java: ## @@ -162,13 +162,14 @@ public void filter(Predicate[] predicate

Re: [PR] Spark: Write DVs for V3 MoR tables [iceberg]

amogh-jahagirdar merged PR #11561: URL: https://github.com/apache/iceberg/pull/11561 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] Spark: Write DVs for V3 MoR tables [iceberg]

amogh-jahagirdar commented on code in PR #11561: URL: https://github.com/apache/iceberg/pull/11561#discussion_r1873680851 ## core/src/main/java/org/apache/iceberg/io/PartitioningDVWriter.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Spark: Write DVs for V3 MoR tables [iceberg]

amogh-jahagirdar commented on code in PR #11561: URL: https://github.com/apache/iceberg/pull/11561#discussion_r1873681281 ## core/src/main/java/org/apache/iceberg/io/PartitioningDVWriter.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Spark: Write DVs for V3 MoR tables [iceberg]

aokolnychyi commented on code in PR #11561: URL: https://github.com/apache/iceberg/pull/11561#discussion_r1872486092 ## core/src/main/java/org/apache/iceberg/io/PartitioningDVWriter.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Spark: Write DVs for V3 MoR tables [iceberg]

amogh-jahagirdar commented on code in PR #11561: URL: https://github.com/apache/iceberg/pull/11561#discussion_r1863716254 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeltaWrite.java: ## @@ -483,6 +493,14 @@ protected PartitioningWriter, Delete

Re: [PR] Spark: Write DVs for V3 MoR tables [iceberg]

amogh-jahagirdar commented on code in PR #11561: URL: https://github.com/apache/iceberg/pull/11561#discussion_r1863714851 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeltaWrite.java: ## @@ -483,6 +493,14 @@ protected PartitioningWriter, Delete

Re: [PR] Spark: Write DVs for V3 MoR tables [iceberg]

amogh-jahagirdar commented on code in PR #11561: URL: https://github.com/apache/iceberg/pull/11561#discussion_r1863707596 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkBatchQueryScan.java: ## @@ -168,7 +168,7 @@ protected Map rewritableDeletes() { f

Re: [PR] Spark: Write DVs for V3 MoR tables [iceberg]

aokolnychyi commented on code in PR #11561: URL: https://github.com/apache/iceberg/pull/11561#discussion_r1859282133 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkBatchQueryScan.java: ## @@ -168,7 +168,7 @@ protected Map rewritableDeletes() { for (S

Re: [PR] Spark: Write DVs for V3 MoR tables [iceberg]

amogh-jahagirdar commented on code in PR #11561: URL: https://github.com/apache/iceberg/pull/11561#discussion_r1854358716 ## core/src/main/java/org/apache/iceberg/io/PartitioningDVWriter.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Spark: Write DVs for V3 MoR tables [iceberg]

amogh-jahagirdar commented on code in PR #11561: URL: https://github.com/apache/iceberg/pull/11561#discussion_r1853989223 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java: ## @@ -521,7 +528,10 @@ public void deleteSingleRecordProdu

Re: [PR] Spark: Write DVs for V3 MoR tables [iceberg]

nastra commented on code in PR #11561: URL: https://github.com/apache/iceberg/pull/11561#discussion_r1851471663 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java: ## @@ -521,7 +528,10 @@ public void deleteSingleRecordProducesDeleteO

Re: [PR] Spark: Write DVs for V3 MoR tables [iceberg]

nastra commented on code in PR #11561: URL: https://github.com/apache/iceberg/pull/11561#discussion_r1851486037 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/SparkRowLevelOperationsTestBase.java: ## @@ -397,4 +450,9 @@ protected void assertAllB

Re: [PR] Spark: Write DVs for V3 MoR tables [iceberg]

nastra commented on code in PR #11561: URL: https://github.com/apache/iceberg/pull/11561#discussion_r1851471897 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java: ## @@ -521,7 +528,10 @@ public void deleteSingleRecordProducesDeleteO