Re: [PR] Spark: Structured Streaming read limit support follow-up [iceberg]

wypoon commented on PR #12260: URL: https://github.com/apache/iceberg/pull/12260#issuecomment-2716153564 @RussellSpitzer would you mind reviewing this when you have some time? It is a small change which @singhpk234 has already reviewed and approved. -- This is an automated message from th

Re: [PR] Spark: Structured Streaming read limit support follow-up [iceberg]

wypoon commented on PR #12260: URL: https://github.com/apache/iceberg/pull/12260#issuecomment-2702852279 @szehon-ho @aokolnychyi would you mind reviewing this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] Spark: Structured Streaming read limit support follow-up [iceberg]

wypoon commented on PR #12260: URL: https://github.com/apache/iceberg/pull/12260#issuecomment-2666966545 @jackye1995 @RussellSpitzer can you please review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Spark: Structured Streaming read limit support follow-up [iceberg]

wypoon commented on PR #12260: URL: https://github.com/apache/iceberg/pull/12260#issuecomment-2659965202 Thanks @singhpk234. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Spark: Structured Streaming read limit support follow-up [iceberg]

wypoon commented on code in PR #12260: URL: https://github.com/apache/iceberg/pull/12260#discussion_r1956540735 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkMicroBatchStream.java: ## @@ -309,6 +312,49 @@ private static StreamingOffset determineStarting

Re: [PR] Spark: Structured Streaming read limit support follow-up [iceberg]

singhpk234 commented on code in PR #12260: URL: https://github.com/apache/iceberg/pull/12260#discussion_r1955584774 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkMicroBatchStream.java: ## @@ -309,6 +312,49 @@ private static StreamingOffset determineStar

Re: [PR] Spark: Structured Streaming read limit support follow-up [iceberg]

wypoon commented on PR #12260: URL: https://github.com/apache/iceberg/pull/12260#issuecomment-2658021202 @singhpk234 @jackye1995 @RussellSpitzer this is a small fix; can you please review? -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Spark: Structured Streaming read limit support follow-up [iceberg]

wypoon commented on code in PR #12260: URL: https://github.com/apache/iceberg/pull/12260#discussion_r1955407420 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestStructuredStreamingRead3.java: ## @@ -206,6 +220,18 @@ public void testReadStreamOnIcebergTableW

Re: [PR] Spark: Structured Streaming read limit support follow-up [iceberg]

wypoon commented on code in PR #12260: URL: https://github.com/apache/iceberg/pull/12260#discussion_r1955405894 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestStructuredStreamingRead3.java: ## @@ -154,8 +154,7 @@ public void testReadStreamOnIcebergTableWi

Re: [PR] Spark: Structured Streaming read limit support follow-up [iceberg]

wypoon commented on code in PR #12260: URL: https://github.com/apache/iceberg/pull/12260#discussion_r1955404930 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkMicroBatchStream.java: ## @@ -458,7 +502,7 @@ public ReadLimit getDefaultReadLimit() {