Re: [PR] Spark: Make `SparkBatch.createReaderFactory` customizable [iceberg]

2025-06-30 Thread via GitHub
zhztheplayer commented on PR #13433: URL: https://github.com/apache/iceberg/pull/13433#issuecomment-3021626382 cc @pvary @huaxingao Would you like to have a look? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Spark: Make `SparkBatch.createReaderFactory` customizable [iceberg]

2025-06-30 Thread via GitHub
zhztheplayer commented on PR #13433: URL: https://github.com/apache/iceberg/pull/13433#issuecomment-3021620518 The feature is now only effective for Spark 4.0. It could be ported to 3.4 and 3.5 after being landed. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Spark: Make `SparkBatch.createReaderFactory` customizable [iceberg]

2025-06-30 Thread via GitHub
zhztheplayer commented on code in PR #13433: URL: https://github.com/apache/iceberg/pull/13433#discussion_r2175544751 ## spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/SparkSQLProperties.java: ## @@ -19,11 +19,18 @@ package org.apache.iceberg.spark; import java.time

Re: [PR] Spark: Make `SparkBatch.createReaderFactory` customizable [iceberg]

2025-06-30 Thread via GitHub
zhztheplayer commented on code in PR #13433: URL: https://github.com/apache/iceberg/pull/13433#discussion_r2175544751 ## spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/SparkSQLProperties.java: ## @@ -19,11 +19,18 @@ package org.apache.iceberg.spark; import java.time