Re: [PR] Spark: Detect temp functions in views [iceberg]

2024-02-26 Thread via GitHub
nastra commented on code in PR #9675: URL: https://github.com/apache/iceberg/pull/9675#discussion_r1502175828 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -102,20 +113,20 @@ case class RewriteViewCommands(s

Re: [PR] Spark: Detect temp functions in views [iceberg]

2024-02-26 Thread via GitHub
nastra commented on code in PR #9675: URL: https://github.com/apache/iceberg/pull/9675#discussion_r1502175277 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -102,20 +113,23 @@ case class RewriteViewCommands(s

Re: [PR] Spark: Detect temp functions in views [iceberg]

2024-02-25 Thread via GitHub
rdblue merged PR #9675: URL: https://github.com/apache/iceberg/pull/9675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Spark: Detect temp functions in views [iceberg]

2024-02-25 Thread via GitHub
rdblue commented on code in PR #9675: URL: https://github.com/apache/iceberg/pull/9675#discussion_r1501871931 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -149,4 +167,20 @@ case class RewriteViewCommands(sp

Re: [PR] Spark: Detect temp functions in views [iceberg]

2024-02-25 Thread via GitHub
rdblue commented on code in PR #9675: URL: https://github.com/apache/iceberg/pull/9675#discussion_r1501871639 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -102,20 +113,20 @@ case class RewriteViewCommands(s

Re: [PR] Spark: Detect temp functions in views [iceberg]

2024-02-25 Thread via GitHub
rdblue commented on code in PR #9675: URL: https://github.com/apache/iceberg/pull/9675#discussion_r1501871166 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -102,20 +113,23 @@ case class RewriteViewCommands(s

Re: [PR] Spark: Detect temp functions in views [iceberg]

2024-02-25 Thread via GitHub
rdblue commented on code in PR #9675: URL: https://github.com/apache/iceberg/pull/9675#discussion_r1501870940 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -471,6 +471,39 @@ public void readFromViewReferencingGlobalTempVie

Re: [PR] Spark: Detect temp functions in views [iceberg]

2024-02-24 Thread via GitHub
nastra commented on code in PR #9675: URL: https://github.com/apache/iceberg/pull/9675#discussion_r1501378409 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -471,6 +471,39 @@ public void readFromViewReferencingGlobalTempVie

Re: [PR] Spark: Detect temp functions in views [iceberg]

2024-02-24 Thread via GitHub
nastra commented on code in PR #9675: URL: https://github.com/apache/iceberg/pull/9675#discussion_r1501376695 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -102,20 +113,23 @@ case class RewriteViewCommands(s

Re: [PR] Spark: Detect temp functions in views [iceberg]

2024-02-24 Thread via GitHub
nastra commented on code in PR #9675: URL: https://github.com/apache/iceberg/pull/9675#discussion_r1501376695 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -102,20 +113,23 @@ case class RewriteViewCommands(s

Re: [PR] Spark: Detect temp functions in views [iceberg]

2024-02-24 Thread via GitHub
nastra commented on code in PR #9675: URL: https://github.com/apache/iceberg/pull/9675#discussion_r1501371107 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -102,20 +113,23 @@ case class RewriteViewCommands(s

Re: [PR] Spark: Detect temp functions in views [iceberg]

2024-02-23 Thread via GitHub
rdblue commented on code in PR #9675: URL: https://github.com/apache/iceberg/pull/9675#discussion_r1501265008 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -102,20 +113,23 @@ case class RewriteViewCommands(s

Re: [PR] Spark: Detect temp functions in views [iceberg]

2024-02-23 Thread via GitHub
rdblue commented on code in PR #9675: URL: https://github.com/apache/iceberg/pull/9675#discussion_r1501266819 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -471,6 +471,39 @@ public void readFromViewReferencingGlobalTempVie

Re: [PR] Spark: Detect temp functions in views [iceberg]

2024-02-23 Thread via GitHub
rdblue commented on code in PR #9675: URL: https://github.com/apache/iceberg/pull/9675#discussion_r1501265932 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -102,20 +113,23 @@ case class RewriteViewCommands(s

Re: [PR] Spark: Detect temp functions in views [iceberg]

2024-02-23 Thread via GitHub
rdblue commented on code in PR #9675: URL: https://github.com/apache/iceberg/pull/9675#discussion_r1501265639 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -149,4 +163,20 @@ case class RewriteViewCommands(sp

Re: [PR] Spark: Detect temp functions in views [iceberg]

2024-02-23 Thread via GitHub
rdblue commented on code in PR #9675: URL: https://github.com/apache/iceberg/pull/9675#discussion_r1501265008 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -102,20 +113,23 @@ case class RewriteViewCommands(s

Re: [PR] Spark: Detect temp functions in views [iceberg]

2024-02-09 Thread via GitHub
nastra commented on code in PR #9675: URL: https://github.com/apache/iceberg/pull/9675#discussion_r1484255806 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -115,7 +124,16 @@ case class RewriteViewCommands(sp

Re: [PR] Spark: Detect temp functions in views [iceberg]

2024-02-09 Thread via GitHub
nastra commented on code in PR #9675: URL: https://github.com/apache/iceberg/pull/9675#discussion_r1484196218 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -149,4 +167,20 @@ case class RewriteViewCommands(sp

Re: [PR] Spark: Detect temp functions in views [iceberg]

2024-02-09 Thread via GitHub
nastra commented on code in PR #9675: URL: https://github.com/apache/iceberg/pull/9675#discussion_r1484192464 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -149,4 +167,20 @@ case class RewriteViewCommands(sp

Re: [PR] Spark: Detect temp functions in views [iceberg]

2024-02-09 Thread via GitHub
nastra commented on code in PR #9675: URL: https://github.com/apache/iceberg/pull/9675#discussion_r1484171305 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -83,6 +88,10 @@ case class RewriteViewCommands(spar

Re: [PR] Spark: Detect temp functions in views [iceberg]

2024-02-08 Thread via GitHub
rdblue commented on code in PR #9675: URL: https://github.com/apache/iceberg/pull/9675#discussion_r1483562486 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -149,4 +167,20 @@ case class RewriteViewCommands(sp

Re: [PR] Spark: Detect temp functions in views [iceberg]

2024-02-08 Thread via GitHub
rdblue commented on code in PR #9675: URL: https://github.com/apache/iceberg/pull/9675#discussion_r1483559483 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -149,4 +167,20 @@ case class RewriteViewCommands(sp

Re: [PR] Spark: Detect temp functions in views [iceberg]

2024-02-08 Thread via GitHub
rdblue commented on code in PR #9675: URL: https://github.com/apache/iceberg/pull/9675#discussion_r1483557926 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -115,7 +124,16 @@ case class RewriteViewCommands(sp

Re: [PR] Spark: Detect temp functions in views [iceberg]

2024-02-08 Thread via GitHub
rdblue commented on code in PR #9675: URL: https://github.com/apache/iceberg/pull/9675#discussion_r1483557926 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -115,7 +124,16 @@ case class RewriteViewCommands(sp

Re: [PR] Spark: Detect temp functions in views [iceberg]

2024-02-07 Thread via GitHub
singhpk234 commented on code in PR #9675: URL: https://github.com/apache/iceberg/pull/9675#discussion_r1481899840 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -149,4 +167,20 @@ case class RewriteViewCommand

Re: [PR] Spark: Detect temp functions in views [iceberg]

2024-02-07 Thread via GitHub
nastra closed pull request #9675: Spark: Detect temp functions in views URL: https://github.com/apache/iceberg/pull/9675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu