Re: [PR] Spark: Change Delete granularity to file for Spark 3.5 [iceberg]

2025-01-03 Thread via GitHub
amogh-jahagirdar merged PR #11478: URL: https://github.com/apache/iceberg/pull/11478 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] Spark: Change Delete granularity to file for Spark 3.5 [iceberg]

2025-01-03 Thread via GitHub
amogh-jahagirdar commented on code in PR #11478: URL: https://github.com/apache/iceberg/pull/11478#discussion_r1901966486 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java: ## @@ -1301,7 +1305,7 @@ public void testDeleteWithMultiple

Re: [PR] Spark: Change Delete granularity to file for Spark 3.5 [iceberg]

2025-01-02 Thread via GitHub
amogh-jahagirdar commented on PR #11478: URL: https://github.com/apache/iceberg/pull/11478#issuecomment-2568629522 Unrelated test failure: ``` TestCopyOnWriteDelete > testDeleteWithSnapshotIsolation() > catalogName = testhive, implementation = org.apache.iceberg.spark.SparkCatalog,

Re: [PR] Spark: Change Delete granularity to file for Spark 3.5 [iceberg]

2025-01-02 Thread via GitHub
RussellSpitzer commented on code in PR #11478: URL: https://github.com/apache/iceberg/pull/11478#discussion_r1901069643 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestUpdate.java: ## @@ -443,7 +447,7 @@ public void testUpdateWithoutCondition

Re: [PR] Spark: Change Delete granularity to file for Spark 3.5 [iceberg]

2025-01-02 Thread via GitHub
RussellSpitzer commented on code in PR #11478: URL: https://github.com/apache/iceberg/pull/11478#discussion_r1901000821 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java: ## @@ -1301,7 +1305,7 @@ public void testDeleteWithMultipleSp

Re: [PR] Spark: Change Delete granularity to file for Spark 3.5 [iceberg]

2025-01-02 Thread via GitHub
RussellSpitzer commented on code in PR #11478: URL: https://github.com/apache/iceberg/pull/11478#discussion_r1901000821 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java: ## @@ -1301,7 +1305,7 @@ public void testDeleteWithMultipleSp

Re: [PR] Spark: Change Delete granularity to file for Spark 3.5 [iceberg]

2024-12-13 Thread via GitHub
aokolnychyi commented on code in PR #11478: URL: https://github.com/apache/iceberg/pull/11478#discussion_r1884625538 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java: ## @@ -719,7 +719,7 @@ public DeleteGranularity deleteGranularity() {