Re: [PR] Spark: Add serialzable isolation test for concurrent MERGE INTOs [iceberg]

2024-10-08 Thread via GitHub
github-actions[bot] closed pull request #9050: Spark: Add serialzable isolation test for concurrent MERGE INTOs URL: https://github.com/apache/iceberg/pull/9050 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Spark: Add serialzable isolation test for concurrent MERGE INTOs [iceberg]

2023-11-28 Thread via GitHub
aokolnychyi commented on code in PR #9050: URL: https://github.com/apache/iceberg/pull/9050#discussion_r1408616725 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java: ## @@ -390,7 +390,7 @@ private Expression conflictDetectionFilter() { fi

Re: [PR] Spark: Add serialzable isolation test for concurrent MERGE INTOs [iceberg]

2023-11-28 Thread via GitHub
aokolnychyi commented on code in PR #9050: URL: https://github.com/apache/iceberg/pull/9050#discussion_r1408616206 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java: ## @@ -390,7 +390,7 @@ private Expression conflictDetectionFilter() { fi

Re: [PR] Spark: Add serialzable isolation test for concurrent MERGE INTOs [iceberg]

2023-11-21 Thread via GitHub
nastra commented on code in PR #9050: URL: https://github.com/apache/iceberg/pull/9050#discussion_r1401516134 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java: ## @@ -390,7 +390,7 @@ private Expression conflictDetectionFilter() { filter

Re: [PR] Spark: Add serialzable isolation test for concurrent MERGE INTOs [iceberg]

2023-11-21 Thread via GitHub
aokolnychyi commented on code in PR #9050: URL: https://github.com/apache/iceberg/pull/9050#discussion_r1401275467 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java: ## @@ -390,7 +390,7 @@ private Expression conflictDetectionFilter() { fi

Re: [PR] Spark: Add serialzable isolation test for concurrent MERGE INTOs [iceberg]

2023-11-15 Thread via GitHub
nastra commented on code in PR #9050: URL: https://github.com/apache/iceberg/pull/9050#discussion_r1394354418 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java: ## @@ -390,7 +390,7 @@ private Expression conflictDetectionFilter() { filter

Re: [PR] Spark: Add serialzable isolation test for concurrent MERGE INTOs [iceberg]

2023-11-14 Thread via GitHub
aokolnychyi commented on code in PR #9050: URL: https://github.com/apache/iceberg/pull/9050#discussion_r1393606348 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java: ## @@ -390,7 +390,7 @@ private Expression conflictDetectionFilter() { fi

Re: [PR] Spark: Add serialzable isolation test for concurrent MERGE INTOs [iceberg]

2023-11-14 Thread via GitHub
aokolnychyi commented on code in PR #9050: URL: https://github.com/apache/iceberg/pull/9050#discussion_r1393606348 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java: ## @@ -390,7 +390,7 @@ private Expression conflictDetectionFilter() { fi

Re: [PR] Spark: Add serialzable isolation test for concurrent MERGE INTOs [iceberg]

2023-11-14 Thread via GitHub
aokolnychyi commented on code in PR #9050: URL: https://github.com/apache/iceberg/pull/9050#discussion_r1393529465 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java: ## @@ -390,7 +390,7 @@ private Expression conflictDetectionFilter() { fi

Re: [PR] Spark: Add serialzable isolation test for concurrent MERGE INTOs [iceberg]

2023-11-14 Thread via GitHub
aokolnychyi commented on code in PR #9050: URL: https://github.com/apache/iceberg/pull/9050#discussion_r1393529465 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java: ## @@ -390,7 +390,7 @@ private Expression conflictDetectionFilter() { fi

Re: [PR] Spark: Add serialzable isolation test for concurrent MERGE INTOs [iceberg]

2023-11-14 Thread via GitHub
aokolnychyi commented on code in PR #9050: URL: https://github.com/apache/iceberg/pull/9050#discussion_r1393529465 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java: ## @@ -390,7 +390,7 @@ private Expression conflictDetectionFilter() { fi

Re: [PR] Spark: Add serialzable isolation test for concurrent MERGE INTOs [iceberg]

2023-11-14 Thread via GitHub
aokolnychyi commented on code in PR #9050: URL: https://github.com/apache/iceberg/pull/9050#discussion_r1393529465 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java: ## @@ -390,7 +390,7 @@ private Expression conflictDetectionFilter() { fi

Re: [PR] Spark: Add serialzable isolation test for concurrent MERGE INTOs [iceberg]

2023-11-14 Thread via GitHub
aokolnychyi commented on code in PR #9050: URL: https://github.com/apache/iceberg/pull/9050#discussion_r1393448207 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java: ## @@ -390,7 +390,7 @@ private Expression conflictDetectionFilter() { fi

Re: [PR] Spark: Add serialzable isolation test for concurrent MERGE INTOs [iceberg]

2023-11-14 Thread via GitHub
aokolnychyi commented on code in PR #9050: URL: https://github.com/apache/iceberg/pull/9050#discussion_r1393448207 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java: ## @@ -390,7 +390,7 @@ private Expression conflictDetectionFilter() { fi

Re: [PR] Spark: Add serialzable isolation test for concurrent MERGE INTOs [iceberg]

2023-11-14 Thread via GitHub
aokolnychyi commented on code in PR #9050: URL: https://github.com/apache/iceberg/pull/9050#discussion_r1393418204 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java: ## @@ -390,7 +390,7 @@ private Expression conflictDetectionFilter() { fi

Re: [PR] Spark: Add serialzable isolation test for concurrent MERGE INTOs [iceberg]

2023-11-14 Thread via GitHub
aokolnychyi commented on code in PR #9050: URL: https://github.com/apache/iceberg/pull/9050#discussion_r1393318722 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java: ## @@ -390,7 +390,7 @@ private Expression conflictDetectionFilter() { fi

Re: [PR] Spark: Add serialzable isolation test for concurrent MERGE INTOs [iceberg]

2023-11-14 Thread via GitHub
nastra commented on code in PR #9050: URL: https://github.com/apache/iceberg/pull/9050#discussion_r1392294340 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java: ## @@ -390,7 +390,7 @@ private Expression conflictDetectionFilter() { filter

Re: [PR] Spark: Add serialzable isolation test for concurrent MERGE INTOs [iceberg]

2023-11-14 Thread via GitHub
nastra commented on code in PR #9050: URL: https://github.com/apache/iceberg/pull/9050#discussion_r1392294340 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java: ## @@ -390,7 +390,7 @@ private Expression conflictDetectionFilter() { filter

Re: [PR] Spark: Add serialzable isolation test for concurrent MERGE INTOs [iceberg]

2023-11-14 Thread via GitHub
nastra commented on code in PR #9050: URL: https://github.com/apache/iceberg/pull/9050#discussion_r1392534466 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMerge.java: ## @@ -2944,4 +2945,77 @@ private RowLevelOperationMode mode(Table table

Re: [PR] Spark: Add serialzable isolation test for concurrent MERGE INTOs [iceberg]

2023-11-14 Thread via GitHub
ajantha-bhat commented on code in PR #9050: URL: https://github.com/apache/iceberg/pull/9050#discussion_r1392528464 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMerge.java: ## @@ -2944,4 +2945,77 @@ private RowLevelOperationMode mode(Table

Re: [PR] Spark: Add serialzable isolation test for concurrent MERGE INTOs [iceberg]

2023-11-14 Thread via GitHub
ajantha-bhat commented on code in PR #9050: URL: https://github.com/apache/iceberg/pull/9050#discussion_r1392502584 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMerge.java: ## @@ -2944,4 +2945,77 @@ private RowLevelOperationMode mode(Table

Re: [PR] Spark: Add serialzable isolation test for concurrent MERGE INTOs [iceberg]

2023-11-14 Thread via GitHub
ajantha-bhat commented on code in PR #9050: URL: https://github.com/apache/iceberg/pull/9050#discussion_r1392502584 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMerge.java: ## @@ -2944,4 +2945,77 @@ private RowLevelOperationMode mode(Table

Re: [PR] Spark: Add serialzable isolation test for concurrent MERGE INTOs [iceberg]

2023-11-14 Thread via GitHub
ajantha-bhat commented on code in PR #9050: URL: https://github.com/apache/iceberg/pull/9050#discussion_r1392489081 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java: ## @@ -401,7 +401,7 @@ private Expression conflictDetectionFilter() { f

Re: [PR] Spark: Add serialzable isolation test for concurrent MERGE INTOs [iceberg]

2023-11-14 Thread via GitHub
ajantha-bhat commented on code in PR #9050: URL: https://github.com/apache/iceberg/pull/9050#discussion_r1392489081 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java: ## @@ -401,7 +401,7 @@ private Expression conflictDetectionFilter() { f

Re: [PR] Spark: Add serialzable isolation test for concurrent MERGE INTOs [iceberg]

2023-11-14 Thread via GitHub
nastra commented on code in PR #9050: URL: https://github.com/apache/iceberg/pull/9050#discussion_r1392294340 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java: ## @@ -390,7 +390,7 @@ private Expression conflictDetectionFilter() { filter

Re: [PR] Spark: Add serialzable isolation test for concurrent MERGE INTOs [iceberg]

2023-11-13 Thread via GitHub
aokolnychyi commented on PR #9050: URL: https://github.com/apache/iceberg/pull/9050#issuecomment-1809442786 I will check tomorrow morning. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec