laithalzyoud commented on PR #10920:
URL: https://github.com/apache/iceberg/pull/10920#issuecomment-2422990247
Thanks @szehon-ho! Will follow up with the implementation PR soon 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
flyrain commented on PR #10920:
URL: https://github.com/apache/iceberg/pull/10920#issuecomment-2423035986
Great! Thanks a lot for working on it, guys!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
szehon-ho commented on PR #10920:
URL: https://github.com/apache/iceberg/pull/10920#issuecomment-2422978173
Merged , thanks @laithalzyoud
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
szehon-ho merged PR #10920:
URL: https://github.com/apache/iceberg/pull/10920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg
szehon-ho commented on code in PR #10920:
URL: https://github.com/apache/iceberg/pull/10920#discussion_r1805455886
##
api/src/main/java/org/apache/iceberg/actions/RewriteTablePath.java:
##
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
flyrain commented on code in PR #10920:
URL: https://github.com/apache/iceberg/pull/10920#discussion_r1805439452
##
api/src/main/java/org/apache/iceberg/actions/RewriteTablePath.java:
##
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
szehon-ho commented on code in PR #10920:
URL: https://github.com/apache/iceberg/pull/10920#discussion_r1804149603
##
api/src/main/java/org/apache/iceberg/actions/RewriteTablePath.java:
##
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
szehon-ho commented on code in PR #10920:
URL: https://github.com/apache/iceberg/pull/10920#discussion_r1804149603
##
api/src/main/java/org/apache/iceberg/actions/RewriteTablePath.java:
##
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
szehon-ho commented on code in PR #10920:
URL: https://github.com/apache/iceberg/pull/10920#discussion_r1804149603
##
api/src/main/java/org/apache/iceberg/actions/RewriteTablePath.java:
##
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
flyrain commented on code in PR #10920:
URL: https://github.com/apache/iceberg/pull/10920#discussion_r1803960871
##
api/src/main/java/org/apache/iceberg/actions/RewriteTablePath.java:
##
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
flyrain commented on code in PR #10920:
URL: https://github.com/apache/iceberg/pull/10920#discussion_r1803960871
##
api/src/main/java/org/apache/iceberg/actions/RewriteTablePath.java:
##
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
szehon-ho commented on code in PR #10920:
URL: https://github.com/apache/iceberg/pull/10920#discussion_r1803788034
##
api/src/main/java/org/apache/iceberg/actions/RewriteTablePath.java:
##
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
szehon-ho commented on code in PR #10920:
URL: https://github.com/apache/iceberg/pull/10920#discussion_r1803788034
##
api/src/main/java/org/apache/iceberg/actions/RewriteTablePath.java:
##
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
laithalzyoud commented on PR #10920:
URL: https://github.com/apache/iceberg/pull/10920#issuecomment-2416696382
Thanks for the review @szehon-ho. I addressed the comments, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
KolonelKustard commented on code in PR #10920:
URL: https://github.com/apache/iceberg/pull/10920#discussion_r1802838771
##
api/src/main/java/org/apache/iceberg/actions/RewriteTablePath.java:
##
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
szehon-ho commented on code in PR #10920:
URL: https://github.com/apache/iceberg/pull/10920#discussion_r1801690970
##
api/src/main/java/org/apache/iceberg/actions/RewriteTablePath.java:
##
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
szehon-ho commented on code in PR #10920:
URL: https://github.com/apache/iceberg/pull/10920#discussion_r1799874793
##
api/src/main/java/org/apache/iceberg/actions/RewriteTablePath.java:
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
szehon-ho commented on code in PR #10920:
URL: https://github.com/apache/iceberg/pull/10920#discussion_r1799852131
##
api/src/main/java/org/apache/iceberg/actions/RewriteTablePath.java:
##
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
flyrain commented on code in PR #10920:
URL: https://github.com/apache/iceberg/pull/10920#discussion_r1799860670
##
api/src/main/java/org/apache/iceberg/actions/RewriteTablePath.java:
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or m
szehon-ho commented on code in PR #10920:
URL: https://github.com/apache/iceberg/pull/10920#discussion_r1799850281
##
api/src/main/java/org/apache/iceberg/actions/RewriteTablePath.java:
##
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
szehon-ho commented on code in PR #10920:
URL: https://github.com/apache/iceberg/pull/10920#discussion_r1799846391
##
api/src/main/java/org/apache/iceberg/actions/RewriteTablePath.java:
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
laithalzyoud commented on PR #10920:
URL: https://github.com/apache/iceberg/pull/10920#issuecomment-2404869540
@szehon-ho PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
laithalzyoud commented on PR #10920:
URL: https://github.com/apache/iceberg/pull/10920#issuecomment-2379580439
Hey @nastra @manuzhang @anuragmantri @flyrain! Can we merge this now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
laithalzyoud commented on PR #10920:
URL: https://github.com/apache/iceberg/pull/10920#issuecomment-2373628194
> > @nastra can you rerun the workflows please? I fixed a formatting error
>
> The formatting error seems to still exist
Should be ok now. Can you rerun again?
--
Th
nastra commented on PR #10920:
URL: https://github.com/apache/iceberg/pull/10920#issuecomment-2373499415
> @nastra can you rerun the workflows please? I fixed a formatting error
The formatting error seems to still exist
--
This is an automated message from the Apache Git Service.
To
laithalzyoud commented on PR #10920:
URL: https://github.com/apache/iceberg/pull/10920#issuecomment-2372335859
@nastra can you rerun the workflows please? I fixed a formatting error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
laithalzyoud commented on PR #10920:
URL: https://github.com/apache/iceberg/pull/10920#issuecomment-2360909503
Hello @nastra @anuragmantri! What's left to merge this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
nastra commented on code in PR #10920:
URL: https://github.com/apache/iceberg/pull/10920#discussion_r1763067211
##
core/src/main/java/org/apache/iceberg/actions/BaseRewriteTablePath.java:
##
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
nastra commented on code in PR #10920:
URL: https://github.com/apache/iceberg/pull/10920#discussion_r1755114815
##
core/src/main/java/org/apache/iceberg/actions/BaseRewriteTablePathActionResult.java:
##
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
laithalzyoud commented on code in PR #10920:
URL: https://github.com/apache/iceberg/pull/10920#discussion_r1739032869
##
api/src/main/java/org/apache/iceberg/actions/RewriteTablePath.java:
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
laithalzyoud commented on code in PR #10920:
URL: https://github.com/apache/iceberg/pull/10920#discussion_r1739029922
##
core/src/main/java/org/apache/iceberg/actions/BaseRewriteTablePathActionResult.java:
##
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (A
laithalzyoud commented on code in PR #10920:
URL: https://github.com/apache/iceberg/pull/10920#discussion_r1739021031
##
api/src/main/java/org/apache/iceberg/actions/RewriteTablePath.java:
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
laithalzyoud commented on code in PR #10920:
URL: https://github.com/apache/iceberg/pull/10920#discussion_r1739021031
##
api/src/main/java/org/apache/iceberg/actions/RewriteTablePath.java:
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
anuragmantri commented on code in PR #10920:
URL: https://github.com/apache/iceberg/pull/10920#discussion_r1725668463
##
core/src/main/java/org/apache/iceberg/actions/BaseRewriteTablePathActionResult.java:
##
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (A
anuragmantri commented on code in PR #10920:
URL: https://github.com/apache/iceberg/pull/10920#discussion_r1725664432
##
api/src/main/java/org/apache/iceberg/actions/RewriteTablePath.java:
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
flyrain commented on PR #10920:
URL: https://github.com/apache/iceberg/pull/10920#issuecomment-2302784375
@amogh-jahagirdar @nastra, @anuragmantri, you may be interested as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
36 matches
Mail list logo