Re: [PR] Revert "feat: Add equality delete writer (#372)" [iceberg-rust]

2024-10-15 Thread via GitHub
Xuanwo commented on PR #672: URL: https://github.com/apache/iceberg-rust/pull/672#issuecomment-2413998124 > @Xuanwo approved since this is a revert PR Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Revert "feat: Add equality delete writer (#372)" [iceberg-rust]

2024-10-15 Thread via GitHub
Xuanwo merged PR #672: URL: https://github.com/apache/iceberg-rust/pull/672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.a

Re: [PR] Revert "feat: Add equality delete writer (#372)" [iceberg-rust]

2024-10-15 Thread via GitHub
kevinjqliu commented on PR #672: URL: https://github.com/apache/iceberg-rust/pull/672#issuecomment-2413989340 @Xuanwo approved since this is a revert PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Revert "feat: Add equality delete writer (#372)" [iceberg-rust]

2024-10-14 Thread via GitHub
Xuanwo commented on PR #672: URL: https://github.com/apache/iceberg-rust/pull/672#issuecomment-2412892346 Hi, @kevinjqliu, could you take a look? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] Revert "feat: Add equality delete writer (#372)" [iceberg-rust]

2024-10-14 Thread via GitHub
Xuanwo opened a new pull request, #672: URL: https://github.com/apache/iceberg-rust/pull/672 This reverts commit ad89eac02712ceac2c3cff6bf0fe5d1b6e289a26. I have to revert PR #372 since it can't pass the unit tests and I didn't find a quick way to fix it. -- This is an automated me