Re: [PR] Revert "Cache Manifest files" [iceberg-python]

2024-09-19 Thread via GitHub
kevinjqliu closed pull request #1167: Revert "Cache Manifest files" URL: https://github.com/apache/iceberg-python/pull/1167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] Revert "Cache Manifest files" [iceberg-python]

2024-09-19 Thread via GitHub
kevinjqliu commented on PR #1167: URL: https://github.com/apache/iceberg-python/pull/1167#issuecomment-2361656656 Closing in favor of #1185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Revert "Cache Manifest files" [iceberg-python]

2024-09-18 Thread via GitHub
kevinjqliu commented on PR #1167: URL: https://github.com/apache/iceberg-python/pull/1167#issuecomment-2359286092 @sungwy here you go https://gist.github.com/kevinjqliu/a0e8e2199bd8064757eb2b40409e0794 -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] Revert "Cache Manifest files" [iceberg-python]

2024-09-17 Thread via GitHub
sungwy commented on PR #1167: URL: https://github.com/apache/iceberg-python/pull/1167#issuecomment-2356731020 > My suspicion is that this is due to the generators in [`read_manifest_list` ](https://github.com/apache/iceberg-python/blob/de47590c6ac4f507cb2337c20504a62c484339f9/pyiceberg/mani

Re: [PR] Revert "Cache Manifest files" [iceberg-python]

2024-09-17 Thread via GitHub
kevinjqliu commented on PR #1167: URL: https://github.com/apache/iceberg-python/pull/1167#issuecomment-2356727162 @sungwy thanks for following up on this. I added more details in the PR description. My suspicion is that this is due to the generators in [`read_manifest_list` ](https:/

Re: [PR] Revert "Cache Manifest files" [iceberg-python]

2024-09-17 Thread via GitHub
sungwy commented on PR #1167: URL: https://github.com/apache/iceberg-python/pull/1167#issuecomment-2356453008 Hi @kevinjqliu thanks for putting this together. Would you mind sharing the verbose exception trace for this issue? Conceptually, I don't think this should result in an error becaus

[PR] Revert "Cache Manifest files" [iceberg-python]

2024-09-12 Thread via GitHub
kevinjqliu opened a new pull request, #1167: URL: https://github.com/apache/iceberg-python/pull/1167 Reverts apache/iceberg-python#787 Integration tests (`make test-integration`) fail when this commit, but only for MacOS. See #1162. -- This is an automated message