Re: [PR] Rest catalog integration testing [iceberg-python]

2025-01-03 Thread via GitHub
kevinjqliu commented on code in PR #1469: URL: https://github.com/apache/iceberg-python/pull/1469#discussion_r1902181377 ## tests/integration/test_rest_catalog.py: ## @@ -16,34 +16,788 @@ # under the License. # pylint:disable=redefined-outer-name + +from typing import Any, D

Re: [PR] Rest catalog integration testing [iceberg-python]

2024-12-29 Thread via GitHub
AhmedNader42 commented on PR #1469: URL: https://github.com/apache/iceberg-python/pull/1469#issuecomment-2564818223 Hello @kevinjqliu, Please can we have a review for this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] Rest catalog integration testing [iceberg-python]

2024-12-25 Thread via GitHub
AhmedNader42 commented on PR #1469: URL: https://github.com/apache/iceberg-python/pull/1469#issuecomment-2561825232 I had a look at the failing tests, and it appears the issue is in the sigv4 authentication option. But I can't reproduce it on local. Any ideas where to proceed from he

[PR] Rest catalog integration testing [iceberg-python]

2024-12-24 Thread via GitHub
AhmedNader42 opened a new pull request, #1469: URL: https://github.com/apache/iceberg-python/pull/1469 This PR resolves #1439 by adding integration tests for the REST Catalog. Functionality testing against the server can be simulated to a certain degree, but some checks are very hard