sungwy commented on code in PR #1155:
URL: https://github.com/apache/iceberg-python/pull/1155#discussion_r1761710974
##
tests/catalog/test_sql.py:
##
@@ -225,6 +237,93 @@ def test_creation_from_impl(catalog_name: str, warehouse:
Path) -> None:
)
+def confirm_no_tables_
isc-patrick commented on PR #1155:
URL: https://github.com/apache/iceberg-python/pull/1155#issuecomment-2344540314
It does not look like CREATE TABLE IF NOT EXISTS is what is used. It is
specific to each dialect and how they implement the has_table method, but the
ones I looked at use metad
kevinjqliu commented on PR #1155:
URL: https://github.com/apache/iceberg-python/pull/1155#issuecomment-2344509223
please do! we want to ensure that this change does not break new and
existing DB integrations.
--
This is an automated message from the Apache Git Service.
To respond to the
isc-patrick commented on PR #1155:
URL: https://github.com/apache/iceberg-python/pull/1155#issuecomment-2344422315
I can certainly add tests, but that is really testing the
Metadata.create_all() function in SQLAlchemy and not pyiceberg code. I think
that CREATE TABLE IF NOT EXISTS requires
