kevinjqliu commented on code in PR #1607:
URL: https://github.com/apache/iceberg-python/pull/1607#discussion_r1951160511
##
tests/catalog/test_sql.py:
##
@@ -1613,3 +1614,50 @@ def test_merge_manifests_local_file_system(catalog:
SqlCatalog, arrow_table_with
tbl.append(
kaushiksrini commented on code in PR #1607:
URL: https://github.com/apache/iceberg-python/pull/1607#discussion_r1948228781
##
pyiceberg/table/__init__.py:
##
@@ -1179,6 +1182,11 @@ def refs(self) -> Dict[str, SnapshotRef]:
def _do_commit(self, updates: Tuple[TableUpdate,
kevinjqliu commented on code in PR #1607:
URL: https://github.com/apache/iceberg-python/pull/1607#discussion_r1948155351
##
pyiceberg/table/__init__.py:
##
@@ -1179,6 +1182,11 @@ def refs(self) -> Dict[str, SnapshotRef]:
def _do_commit(self, updates: Tuple[TableUpdate, ..
kaushiksrini commented on PR #1607:
URL: https://github.com/apache/iceberg-python/pull/1607#issuecomment-2646423584
@kevinjqliu thanks for the review! I moved the logic after the table is
committed
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
kevinjqliu commented on code in PR #1607:
URL: https://github.com/apache/iceberg-python/pull/1607#discussion_r1947923652
##
mkdocs/docs/configuration.md:
##
@@ -63,6 +63,7 @@ Iceberg tables support table properties to configure table
behavior.
| `write.parquet.page-row-limit`
kaushiksrini commented on PR #1607:
URL: https://github.com/apache/iceberg-python/pull/1607#issuecomment-2644180446
@Fokko thanks! used context managers and added to the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
Fokko commented on code in PR #1607:
URL: https://github.com/apache/iceberg-python/pull/1607#discussion_r1946894264
##
tests/catalog/test_sql.py:
##
@@ -1613,3 +1614,60 @@ def test_merge_manifests_local_file_system(catalog:
SqlCatalog, arrow_table_with
tbl.append(arrow
kaushiksrini opened a new pull request, #1607:
URL: https://github.com/apache/iceberg-python/pull/1607
Implements property `write.metadata.delete-after-commit.enabled` from
https://iceberg.apache.org/docs/1.5.1/maintenance/#remove-old-metadata-files.
Closes #1199
--
This is an aut
