Fokko merged PR #1416:
URL: https://github.com/apache/iceberg-python/pull/1416
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceber
Fokko commented on code in PR #1416:
URL: https://github.com/apache/iceberg-python/pull/1416#discussion_r1902135055
##
tests/expressions/test_parser.py:
##
@@ -70,7 +70,6 @@ def test_equals_false() -> None:
def test_is_null() -> None:
assert IsNull("foo") == parser.parse("
kevinjqliu commented on code in PR #1416:
URL: https://github.com/apache/iceberg-python/pull/1416#discussion_r1894101745
##
tests/expressions/test_parser.py:
##
@@ -70,7 +70,6 @@ def test_equals_false() -> None:
def test_is_null() -> None:
assert IsNull("foo") == parser.pa
Fokko commented on code in PR #1416:
URL: https://github.com/apache/iceberg-python/pull/1416#discussion_r1894094791
##
tests/expressions/test_parser.py:
##
@@ -70,7 +70,6 @@ def test_equals_false() -> None:
def test_is_null() -> None:
assert IsNull("foo") == parser.parse("
kevinjqliu commented on PR #1416:
URL: https://github.com/apache/iceberg-python/pull/1416#issuecomment-2557233390
done! @Fokko can you take another look? ran locally no warnings in
`make-test`
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
Fokko commented on PR #1416:
URL: https://github.com/apache/iceberg-python/pull/1416#issuecomment-2557111091
@kevinjqliu can you rebase this one? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
kevinjqliu commented on code in PR #1416:
URL: https://github.com/apache/iceberg-python/pull/1416#discussion_r1874539222
##
pyiceberg/utils/deprecated.py:
##
@@ -56,7 +56,6 @@ def deprecation_message(deprecated_in: str, removed_in: str,
help_message: Optio
def _deprecation_w
kevinjqliu opened a new pull request, #1416:
URL: https://github.com/apache/iceberg-python/pull/1416
Fix these errors in `make-test`:
* tests/table/test_name_mapping.py::test_mapping_lookup_by_name
`Call to find, deprecated in 0.8.0, will be removed in 0.9.0. Please use
`apply_name_map
